Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

promo ui updates #26733

Merged
merged 1 commit into from
May 12, 2023
Merged

Conversation

warrensplayer
Copy link
Contributor

@warrensplayer warrensplayer commented May 11, 2023

Updates to Promo UI to align better with designs

  • Pulled more recent SVG from Figma for record-guide.svg that has a width/height ratio that matches the other images
    • Exported SVG has a drop shadow that causes the SVG to be bigger to contain the shadow. Added negative margins and fixed height wrapper with overflow to allow for the shadow.
  • Used hardcoded widths for 2 column grid to keep images from resizing (could perhaps push those widths down to the content, but did not do that)
    • It now changes at the xl breakpoint to make sure the 2 columns have enough width
  • Refactoring PromoAction to not fight with the Button styles so much
  • moved shadow style to utility class

@warrensplayer warrensplayer marked this pull request as ready for review May 11, 2023 19:58
Copy link
Contributor

@mike-plummer mike-plummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixed pixel widths make me 😢 , but I guess it's necessary to match the designs.

@cypress
Copy link

cypress bot commented May 11, 2023

4 failed and 28 flaky tests on run #46181 ↗︎

4 27292 1307 0 Flakiness 28

Details:

promo ui updates
Project: cypress Commit: b4e7fd63fe
Status: Failed Duration: 20:40 💡
Started: May 11, 2023 8:10 PM Ended: May 11, 2023 8:31 PM
Failed  e2e/origin/commands/waiting.cy.ts • 1 failed test • 5x-driver-electron

View Output Video

Test Artifacts
cy.origin waiting > alias > waits for the route alias to have a response Output Video
Failed  e2e/origin/user_agent_override.cy.ts • 1 failed test • 5x-driver-electron

View Output Video

Test Artifacts
user agent override > persists modified user agent after cy.go Output Video
Failed  runs.cy.ts • 2 failed tests • app-e2e

View Output Video

Test Artifacts
App: Runs > Runs - No Runs > displays how to record prompt when connected and no runs in Component Testing Output Screenshots Video
App: Runs > Runs - No Runs > displays how to record prompt when connected and no runs in E2E Output Screenshots Video
Flakiness  cypress/e2e/commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output
Flakiness  cypress/e2e/e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
cy.origin assertions > #consoleProps > .should() and .and() Output
Flakiness  cypress/e2e/cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  src/debug/DebugSpec.cy.tsx • 1 flaky test • app-ct

View Output Video

Test Artifacts
with multiple test results > mounts correctly for single groups Output Video
Flakiness  cypress/e2e/cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

The first 5 flaky specs are shown, see all 15 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mike-plummer mike-plummer merged commit caa2b1f into mikep/26181-aci-empty-states May 12, 2023
@mike-plummer mike-plummer deleted the stokes/promo_ui_updates branch May 12, 2023 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants