-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
promo ui updates #26733
Merged
mike-plummer
merged 1 commit into
mikep/26181-aci-empty-states
from
stokes/promo_ui_updates
May 12, 2023
Merged
promo ui updates #26733
mike-plummer
merged 1 commit into
mikep/26181-aci-empty-states
from
stokes/promo_ui_updates
May 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mike-plummer
approved these changes
May 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fixed pixel widths make me 😢 , but I guess it's necessary to match the designs.
4 failed and 28 flaky tests on run #46181 ↗︎
Details:
e2e/origin/commands/waiting.cy.ts • 1 failed test • 5x-driver-electron
e2e/origin/user_agent_override.cy.ts • 1 failed test • 5x-driver-electron
runs.cy.ts • 2 failed tests • app-e2ecypress/e2e/commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
cypress/e2e/e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
cypress/e2e/cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
src/debug/DebugSpec.cy.tsx • 1 flaky test • app-ct
cypress/e2e/cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
The first 5 flaky specs are shown, see all 15 specs in Cypress Cloud. This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to Promo UI to align better with designs
record-guide.svg
that has a width/height ratio that matches the other imagesxl
breakpoint to make sure the 2 columns have enough widthPromoAction
to not fight with the Button styles so much