-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: create lists files after folders when in same directory in specs list #26723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 failed and 31 flaky tests on run #46111 ↗︎
Details:
cypress/e2e/scaffold-project.cy.ts • 1 failed test • launchpad-e2e
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
create-from-component.cy.ts • 1 flaky test • app-e2e
specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e
debug.cy.ts • 1 flaky test • app-e2e
The first 5 flaky specs are shown, see all 18 specs in Cypress Cloud. This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
chrisbreiding
approved these changes
May 12, 2023
chrisbreiding
requested review from
marktnoonan
and removed request for
marktnoonan
May 12, 2023 14:01
mjhenkes
approved these changes
May 15, 2023
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
The PR guarantee that the ordering, specifically, was rendering correctly. The unique file that will be affected by this change is the file
packages/app/cypress/e2e/specs_list_e2e.cy.ts
.Nothing will be affected by this change, except the file specs_list_e2e.cy.ts, responsible to test cypress-in-cypress e2e.
I implemented getting the element by id because the current state of project don't have any format to diff one row-directory of another, same as the files.
The 9.0 test is here: https://github.com/cypress-io/cypress/blob/ba1c85bc20398e98c5920a2fe157ae3c385ff556/packages/desktop-gui/cypress/integration/specs_list_spec.js#L283
Steps to test
PR Tasks
cypress-documentation
?type definitions
?