Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: create lists files after folders when in same directory in specs list #26723

Merged
merged 2 commits into from
May 15, 2023
Merged

test: create lists files after folders when in same directory in specs list #26723

merged 2 commits into from
May 15, 2023

Conversation

luis-furtado
Copy link
Contributor

@luis-furtado luis-furtado commented May 10, 2023

Additional details

The PR guarantee that the ordering, specifically, was rendering correctly. The unique file that will be affected by this change is the file packages/app/cypress/e2e/specs_list_e2e.cy.ts.

Nothing will be affected by this change, except the file specs_list_e2e.cy.ts, responsible to test cypress-in-cypress e2e.

I implemented getting the element by id because the current state of project don't have any format to diff one row-directory of another, same as the files.

The 9.0 test is here: https://github.com/cypress-io/cypress/blob/ba1c85bc20398e98c5920a2fe157ae3c385ff556/packages/desktop-gui/cypress/integration/specs_list_spec.js#L283

Steps to test

  1. Go to the front-end cypress project
  2. Specifically run the e2e test from the file cypress/e2e/specs_list_e2e.cy.ts

PR Tasks

@CLAassistant
Copy link

CLAassistant commented May 10, 2023

CLA assistant check
All committers have signed the CLA.

@cypress
Copy link

cypress bot commented May 10, 2023

1 failed and 31 flaky tests on run #46111 ↗︎

1 27291 1307 0 Flakiness 31

Details:

test: create lists files after folders when in same directory in specs list
Project: cypress Commit: 02a8421cde
Status: Failed Duration: 21:30 💡
Started: May 10, 2023 8:23 PM Ended: May 10, 2023 8:45 PM
Failed  cypress/e2e/scaffold-project.cy.ts • 1 failed test • launchpad-e2e

View Output Video

Test Artifacts
scaffolding new projects > generates valid config file for pristine project without cypress installed Output Screenshots Video
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  create-from-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  debug.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App - Debug Page > shows information about a failed spec Output Screenshots Video

The first 5 flaky specs are shown, see all 18 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@chrisbreiding chrisbreiding requested review from marktnoonan and removed request for marktnoonan May 12, 2023 14:01
@marktnoonan marktnoonan merged commit bac3032 into cypress-io:develop May 15, 2023
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 23, 2023

Released in 12.13.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.13.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test: App - Spec Lists - List files after folder when in the same directory.
5 participants