Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add telemetry to the proxy #26695
chore: add telemetry to the proxy #26695
Changes from all commits
0da3f04
d99cdd4
54aaa3b
01c1efc
cd79147
693e8fe
958067d
3d87b88
b1932c0
96c1d21
3f1561f
5fac6fc
63bc55c
69f528d
b5ae111
4b9e414
473cb73
79e6c27
da073fd
2c16cae
c70fbbd
e6d543f
c7b68ba
101370e
fab0bde
8fd414b
3522cbe
f69d6b9
c25ebf8
6becdce
59025ae
afdbae1
1be8cd1
4a3d207
4574358
98b8c23
f7b860b
b7b9e83
bc31ab5
f3a0bf4
7b16e05
4f1835b
3b533ac
deb28f2
21e5594
bb0fbdd
3ca6bba
ac6bf6a
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double checking - Should this be command:fails OR command:skipped dep on the command state of queued vs pending?
this would be primarily observers around cy.session spans and error handling if I remember corretly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't expect skipped to count as an error. There is an explicit
skipped:command:end
message called. Even so, the span would be ended with the state logged, but it would also include the error.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this exported and why is this hard-coded to true?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a single place to control the verbose telemetry flag for the proxy, the request and response middle-wares both import it.