Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: ACI empty state slideshows #26692

Merged
merged 19 commits into from
May 12, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion cli/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,17 @@
<!-- See the ../guides/writing-the-cypress-changelog.md for details on writing the changelog. -->
## 12.12.1

_Released 05/14/2023 (PENDING)_
_Released 05/23/2023 (PENDING)_

**Bugfixes:**

- Reverted [#26452](https://github.com/cypress-io/cypress/pull/26630) which introduced a bug that prevents users from using End to End with Yarn 3. Fixed in [#26735](https://github.com/cypress-io/cypress/pull/26735). Fixes [#26676](https://github.com/cypress-io/cypress/issues/26676).
- Moved `types` condition to the front of `package.json#exports` since keys there are meant to be order-sensitive. Fixed in [#26630](https://github.com/cypress-io/cypress/pull/26630).

**Misc:**

- Updated styling & content of Cypress Cloud slideshows when not logged in or no runs have been recorded. Addresses [#26181](https://github.com/cypress-io/cypress/issues/26181).

## 12.12.0

_Released 05/09/2023_
Expand Down
4 changes: 1 addition & 3 deletions packages/app/cypress/e2e/runs.cy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -577,7 +577,7 @@ describe('App: Runs', { viewportWidth: 1200 }, () => {
})
})

context('Runs - No Runs', () => {
context('Runs - No Runs', { viewportWidth: 1280 }, () => {
it('when no runs and not connected, shows connect to Cypress Cloud button', () => {
cy.scaffoldProject('component-tests')
cy.openProject('component-tests', ['--config-file', 'cypressWithoutProjectId.config.js'])
Expand All @@ -602,15 +602,13 @@ describe('App: Runs', { viewportWidth: 1200 }, () => {
it('displays how to record prompt when connected and no runs in Component Testing', () => {
scaffoldTestingTypeAndVisitRunsPage('component')
cy.contains(defaultMessages.runs.empty.title).should('be.visible')
cy.contains(defaultMessages.runs.empty.description).should('be.visible')
cy.findByDisplayValue('npx cypress run --component --record --key 2aaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa').should('be.visible')
})

it('displays how to record prompt when connected and no runs in E2E', () => {
scaffoldTestingTypeAndVisitRunsPage('e2e')

cy.contains(defaultMessages.runs.empty.title).should('be.visible')
cy.contains(defaultMessages.runs.empty.description).should('be.visible')
cy.findByDisplayValue('npx cypress run --record --key 2aaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa').should('be.visible')
})

Expand Down
Binary file removed packages/app/src/assets/debug-guide-skeleton-1.png
Binary file not shown.
68 changes: 68 additions & 0 deletions packages/app/src/assets/debug-guide-skeleton-1.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed packages/app/src/assets/debug-guide-skeleton-2.png
Binary file not shown.
Loading