Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding command log to protocol #26387

Merged
merged 9 commits into from
Apr 5, 2023

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Mar 31, 2023

Additional details

  • Calls protocol.commandLogAdded when the Cypress.on(log:added) event is triggered.
  • Calls protocol.commandLogChanged when the Cypress.on(log:changed) event is triggered.
  • Updated tests that were spying/stubbing Cypress.backend to not log since that will now cause an infinite loop where we log the spy/stub and then call the backend again for the protocol which causes a log for the spy/stub and so on.

Steps to test

  • Clone the cypress-services repo and checkout mschile/protocol/add_command_log
    • Run yarn
    • Run yarn watch-protocol
  • Set CYPRESS_LOCAL_PROTOCOL_PATH to the path to cypress-services/packages/app-capture-protocol/dist/index.js
  • Clone the cypress repo and checkout mschile/protocol/add_command_log
    • Run yarn
    • Execute cypress run on a project in record mode with DEBUG set to cypress:*protocol* and ensure the command:log events are added to the database.

How has the user experience changed?

PR Tasks

@cypress
Copy link

cypress bot commented Apr 4, 2023

3 flaky tests on run #45282 ↗︎

0 5121 74 0 Flakiness 3

Details:

more backend fixes
Project: cypress Commit: 202f8921cc
Status: Passed Duration: 14:49 💡
Started: Apr 5, 2023 3:37 AM Ended: Apr 5, 2023 3:52 AM
Flakiness  cypress/e2e/cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@ryanthemanuel ryanthemanuel merged commit c227362 into feat/protocol Apr 5, 2023
@ryanthemanuel ryanthemanuel deleted the mschile/protocol/add_command_log branch April 5, 2023 14:41
tgriesser added a commit that referenced this pull request Apr 11, 2023
* feat/protocol:
  chore: update vm2 to 3.9.15 (#26467)
  chore: adding wallClockUpdatedAt to log for protocol (#26450)
  chore: update protocol from develop (#26433)
  chore: adding command log to protocol (#26387)
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants