-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding command log to protocol #26387
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
approved these changes
Mar 31, 2023
ryanthemanuel
approved these changes
Apr 3, 2023
3 flaky tests on run #45282 ↗︎
Details:
cypress/e2e/cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
protocol.commandLogAdded
when theCypress.on(log:added)
event is triggered.protocol.commandLogChanged
when theCypress.on(log:changed)
event is triggered.Cypress.backend
to not log since that will now cause an infinite loop where we log the spy/stub and then call the backend again for the protocol which causes a log for the spy/stub and so on.Steps to test
cypress-services
repo and checkoutmschile/protocol/add_command_log
yarn
yarn watch-protocol
CYPRESS_LOCAL_PROTOCOL_PATH
to the path tocypress-services/packages/app-capture-protocol/dist/index.js
cypress
repo and checkoutmschile/protocol/add_command_log
yarn
cypress run
on a project in record mode withDEBUG
set tocypress:*protocol*
and ensure thecommand:log
events are added to the database.How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?