Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding runnables to protocol #26171

Merged
merged 8 commits into from
Mar 24, 2023

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Mar 22, 2023

Additional details

This PR adds the runnables to the protocol.

Steps to test

  • Clone the cypress-services repo and checkout mschile/protocol/add_runnables
    • Run yarn
    • Run yarn watch in packages/app-capture-protocol
  • Set CYPRESS_LOCAL_PROTOCOL_PATH to the path to cypress-services/packages/app-capture-protocol/dist/index.js
  • Clone the cypress repo and checkout mschile/protocol/add_runnables
    • Run yarn
    • Execute cypress run on a project in record mode with DEBUG set to cypress:*protocol* and ensure the runnables are added to the database.

How has the user experience changed?

Screenshot 2023-03-21 at 8 56 21 PM

PR Tasks

@cypress
Copy link

cypress bot commented Mar 22, 2023

24 flaky tests on run #44933 ↗︎

0 26890 1281 0 Flakiness 24

Details:

Merge branch 'feat/protocol' into mschile/protocol/add_runnables
Project: cypress Commit: bfe0f3491d
Status: Passed Duration: 20:47 💡
Started: Mar 23, 2023 10:33 PM Ended: Mar 23, 2023 10:54 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox

View Output Video

Test Artifacts
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
... > correctly returns currentRetry Output
Flakiness  create-from-component.cy.ts • 2 flaky tests • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
... > runs generated spec Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video

The first 5 flaky specs are shown, see all 11 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mschile mschile requested a review from ryanthemanuel March 22, 2023 04:51
Base automatically changed from ryanm/chore/better-sqlite3 to feat/protocol March 23, 2023 17:01
Copy link
Collaborator

@ryanthemanuel ryanthemanuel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (with the update from the feature branch)

@mschile mschile merged commit 530397f into feat/protocol Mar 24, 2023
@mschile mschile deleted the mschile/protocol/add_runnables branch March 24, 2023 00:21
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants