chore: initial protocol api work #26080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mschile
reviewed
Mar 10, 2023
mschile
reviewed
Mar 10, 2023
packages/server/lib/cloud/api.ts
Outdated
| @@ -330,6 +331,12 @@ module.exports = { | |||
| }) | |||
| }) | |||
| }) | |||
| .then(async (result) => { | |||
| // TODO: Get url for the protocol code and pass it down to download | |||
There was a problem hiding this comment.
Suggest namespacing all the TODOs so we can easily verify that all the TODOs have been completed.
Suggested change
| // TODO: Get url for the protocol code and pass it down to download | |
| // TODO(protocol): Get url for the protocol code and pass it down to download |
mschile
reviewed
Mar 10, 2023
mschile
reviewed
Mar 10, 2023
mschile
reviewed
Mar 10, 2023
mschile
reviewed
Mar 10, 2023
mschile
reviewed
Mar 10, 2023
mschile
reviewed
Mar 10, 2023
mschile
reviewed
Mar 10, 2023
mschile
reviewed
Mar 10, 2023
mschile
reviewed
Mar 10, 2023
mschile
reviewed
Mar 10, 2023
mschile
reviewed
Mar 11, 2023
mschile
reviewed
Mar 11, 2023
mschile
approved these changes
Mar 11, 2023
Co-authored-by: Matt Schile <[email protected]>
27 flaky tests on run #44711 ↗︎
Details:
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
Video
|
|
| ... > correctly returns currentRetry |
Output
Video
|
|
| ... > correctly returns currentRetry |
Output
Video
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| network stubbing > intercepting request > can delay and throttle a StaticResponse |
Output
|
|
e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| cy.origin assertions > #consoleProps > .should() and .and() |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
create-from-component.cy.ts • 2 flaky tests • app-e2e
| Test | Artifacts | |
|---|---|---|
| ... > runs generated spec |
Output
Screenshots
Video
|
|
| ... > runs generated spec |
Output
Screenshots
Video
|
|
The first 5 flaky specs are shown, see all 14 specs in Cypress Cloud.
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
mjhenkes
approved these changes
Mar 13, 2023
ryanthemanuel
changed the title
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This is an initial base implementation of hooking into the protocol API that will be delivered from the cloud. It hooks into the lifecycle of specs, tests, and browser connections.
Steps to test
cypress-servicesrepoyarnyarn watchinpackages/app-capture-protocolCYPRESS_LOCAL_PROTOCOL_PATHto the path tocypress-services/packages/app-capture-protocol/dist/index.jscypressrepoyarncypress runon a project in record mode withDEBUGset tocypress:*protocol*and ensure you can see the lifecycle eventsHow has the user experience changed?
n/a
PR Tasks
cypress-documentation?type definitions?