Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updating the remaining triage github actions to be reusable #25903

Merged
merged 1 commit into from
Feb 21, 2023

Conversation

nagash77
Copy link
Contributor

updating the remaining triage github actions to be reusable by other repos in the Cypress org

  • Closes

Additional details

This will allow us to have github actions in other repos in the org call the triage functions that live in this repo

Steps to test

How has the user experience changed?

PR Tasks

@nagash77 nagash77 requested review from mschile and mjhenkes February 21, 2023 18:42
# makes this workflow reusable
workflow_call:
secrets:
ADD_TO_TRIAGE_BOARD_TOKEN:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary on this PR but we should probably change the name of this token since it's used for more than just adding to the triage project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I was thinking about that. The other uses are less "invasive" in my opinion like moving a ticket between columns on the project board so I think it is ok for the moment that the ticket at least shows its most powerful permission in the name.

@nagash77 nagash77 merged commit 49fdb6b into develop Feb 21, 2023
@nagash77 nagash77 deleted the benm/make-triage-gh-actions-reusable branch February 21, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants