chore: update workflows.yml to include the v8 snapshot update branch #25784

ryanthemanuel · 2023-02-13T15:19:31Z

Additional details

Ensure that branch created via the auto updating github action will be fully tested.
Updates the bot token that's used since we can't use the built in github token with circle ci contexts.
Update the non full regeneration to be a nightly build instead of on each commit

Steps to test

n/a

How has the user experience changed?

n/a

PR Tasks

[na] Have tests been added/updated?
[na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
[na] Has a PR for user-facing changes been opened in cypress-documentation?
[na] Have API changes been updated in the type definitions?

emilyrohrbough · 2023-02-13T15:38:14Z

.circleci/workflows.yml

@@ -28,7 +28,8 @@ mainBuildFilters: &mainBuildFilters
      only:
        - develop
        - /^release\/\d+\.\d+\.\d+$/
-        - 'mikep/22825-next-middleware'
+        # use the following branch as well to ensure that v8 snapshot cache updates are fully tested
+        - 'update-v8-snapshot-cache-on-develop'


Do we need to update line 137 to always persist and run the full binary tests on this branch? https://github.com/cypress-io/cypress/pull/25784/files#diff-7bf091450b804ea25dc3d11ac28c50202d19178f7b53f54a02ad59c946afa6a7R137

Updated: 4fcc2ef (#25784)

cypress · 2023-02-13T15:51:12Z

40 flaky tests on run #44087 ↗︎

0	26802	1271	0	40

Details:

Merge branch 'develop' into ryanthemanuel-patch-2
Project: cypress	Commit: `99fc2bb407`
Status: Passed	Duration: 19:09 💡
Started: Feb 14, 2023 7:04 PM	Ended: Feb 14, 2023 7:23 PM

create-from-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test
... > runs generated spec		`Screenshot`

specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs		`Screenshot`

cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution		`Screenshot`

debug.cy.ts • 1 flaky test • app-e2e

View Output Video

Test
App - Debug Page > shows information about a failed spec		`Screenshot`

commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test
network stubbing > intercepting request > can delay and throttle a StaticResponse

The first 5 flaky specs are shown, see all 18 specs in Cypress Cloud.

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

.github/workflows/update_v8_snapshot_cache.yml

emilyrohrbough · 2023-02-13T17:28:09Z

.github/workflows/update_v8_snapshot_cache.yml

@@ -1,6 +1,8 @@
 name: Update V8 Snapshot Cache
 on:
  schedule:
+    # Run everyday at 00:00 UTC
+    - cron: '0 0 * * *'


Can we remove develop from list of branches?

mjhenkes · 2023-02-13T17:28:35Z

.github/workflows/update_v8_snapshot_cache.yml

    # Run every Wednesday at 00:00 UTC
    - cron: '0 0 * * 3'


Still need this chron if you already run every day at 00:00 UTC?

Doh. Good call. I updated this to be correct with what I'm thinking. The logic is now:

Every day except wednesday: iterative regeneration

Wednesday: full regeneration

Release branches: every commit

mjhenkes · 2023-02-13T17:29:49Z

.github/workflows/update_v8_snapshot_cache.yml

@@ -35,7 +37,8 @@ jobs:
    env:
      CYPRESS_BOT_APP_ID: ${{ secrets.RAM_APP }}
      BASE_BRANCH: ${{ inputs.branch || github.ref_name }}
-      GENERATE_FROM_SCRATCH: ${{ inputs.generate_from_scratch == true || github.event_name == 'schedule' }}
+      # Flex the generate from scratch option based on manual input or if we are on the weekly schedule
+      GENERATE_FROM_SCRATCH: ${{ inputs.generate_from_scratch == true || (github.event_name == 'schedule' && github.event.schedule == '0 0 * * 3') }}


should this one be every day too or only on Wednesday?

I want "from scratch" to happen weekly. And the other one to happen daily.

* fix: update newProject ref when switching between organizations in SelectCloudProjectModal (#25730) * chore: debug page tooltip distance and artifact border (#25727) * misc: debug page tooltip distance and artifact border * add changelog entry * fix CT test * fix: Improve error handling around calls to `this.next` in middleware (#25702) * chore: update changelog validation example (#25742) * misc: improve debug loading text wrap responsiveness (#25703) * misc: Increase max failures in IATR badge to 99 (#25737) * chore: exclude collaborator issues/PRs from triage project (#25769) * feat: add --auto-cancel-after-failures flag (#25237) Co-authored-by: Emily Rohrbough <[email protected]> Co-authored-by: Matt Schile <[email protected]> Co-authored-by: Ryan Pei <[email protected]> Co-authored-by: Emily Rohrbough <[email protected]> * chore: Update v8 snapshot cache (#25592) * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * Update update_v8_snapshot_cache.yml * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache * chore: updating v8 snapshot cache --------- Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <[email protected]> Co-authored-by: cypress-bot[bot] <47117332+cypress-bot[bot]@users.noreply.github.com> * fix: implement new graphql fields for spec counts (#25757) Co-authored-by: Stokes Player <[email protected]> Co-authored-by: Mike Plummer <[email protected]> * feat: Bundle cy.origin() dependencies at runtime (#25626) Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <[email protected]> * chore: remove zenhub from release process (#25701) Co-authored-by: Matt Schile <[email protected]> * feat: add Cypress.Commands.overwriteQuery (#25674) * feat: add Cypress.Commands.overwriteQuery Co-authored-by: Emily Rohrbough <[email protected]> Co-authored-by: Zach Bloomquist <[email protected]> * fix: spawn child process with process.env in macOS arm64 (#25753) Co-authored-by: Matt Schile <[email protected]> Co-authored-by: Emily Rohrbough <[email protected]> Co-authored-by: Zach Bloomquist <[email protected]> * chore: lint system tests in CI (#25673) * fix: Suppress filesystem errors during glob search (#25774) * chore: issue with ts-loader missing in binary and problematic esbuild norewrite construct (#25797) * chore: update changelog linting (#25809) * docs(guides): add more detail to code-signing (#25794) Co-authored-by: Emily Rohrbough <[email protected]> * chore: update workflows.yml to include the v8 snapshot update branch (#25784) Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> * chore: internal request preflight (#25772) --------- Co-authored-by: Emily Rohrbough <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <[email protected]> Co-authored-by: Matt Henkes <[email protected]> Co-authored-by: Zach Bloomquist <[email protected]> * chore: bump for 12.6.0 release (#25812) * chore: release @cypress/webpack-batteries-included-preprocessor-v2.4.0 [skip ci] * chore: release @cypress/webpack-preprocessor-v5.17.0 [skip ci] * test: skip flaky GitDataSource test (#25825) * chore: making our add-to-triage-board workflow reusable within the Cypress-io org (#25820) * chore: Making our add to triage workflow callable from other projects inside the Cypress-io org in Github * chore: updated cypress-example-kitchensink version (#25828) * fix: duplicate and expired cookies (#25761) * chore: add regression tests for duplicate cookies and bad expiry times * avoid prepending domain with dot for cookies that are set with the server side jar. This is to avoid the cookie being duplicated if it is set or overridden in a different context (request that can actually set the cookie or via document.domain) * feat: use cookie.toString() in the cookie patch to more accurately set cookies on the document, which should include other properties besides key=value * fix: add logic to handle expired cookies in the document.cookie patch, as well as in CDP * chore: build binary for cookie fixes for users to test * chore: change name of fixture to something more accurate * chore: comment why we are using the toughCookie toString method in the patch * [run ci] * chore: add changelog entry * [run ci] * fix: revert back to key=value when getting document.cookie as those are the only values are displayed (oversight on my end) * [run ci] * chore: make compatible with cypress.require * fix: add tests for hostOnly/non hostOnly cookies to make sure property gets sent up to automation client correctly. No longer need custom cookie prop to determine destination * [run ci] * fix: stale unit test * chore: adjust comments * [run ci] * fix: bad domain logic * [run ci] * chore: remove irrelevant comment * [run ci] * fix: adjust cookie login text to spec hostOnly cookie within the cookie patch. This should yield the same behavior as we are bound to same origin within the spec bridge * [run ci] * [run ci] * fix: allow for cookies on request of same key to take precedence over cookies in the jar, regardless of how many hierachy cookies exist in the jar * chore: fix cookie misc tests for cy.origin (dont run cy.origin) * [run ci] * chore: skip misc cookie tests in webkit as headless behavior doesn't clear cookies between tests correctly * Revert "fix: allow for cookies on request of same key to take precedence over cookies in the jar, regardless of how many hierachy cookies exist in the jar" This reverts commit 17de188. * [run ci] * chore: split changelog entry into two parts * chore: update logic to remove else statement and add comments * [run ci] * chore: readd windows snapshot branch in workflows * [run ci] * chore: fix workflows from bad merge * [run ci] * Revert "chore: split changelog entry into two parts" This reverts commit 4352ef5. * [run ci] * fix: Fix type definitions for cy.reload() (#25779) Co-authored-by: Emily Rohrbough <[email protected]> * misc: Debug header updates (#25823) * fix: allow running tests outside Vite project root folder (#25801) * fix: allow running tests outside Vite project root folder * update snapshots * add changelog entry --------- Co-authored-by: Lachlan Miller <[email protected]> * fix: mount component in [data-cy-root] (#25807) * fix(angular): mount component in [data-cy-root] * fix e2e test * add changelog entry * changelog [skip ci] * changelog --------- Co-authored-by: Lachlan Miller <[email protected]> * chore: updating add to triage baord github action to use org secret (#25868) * chore: updating add to triage board github action to use org secret * chore: release @cypress/angular-v2.0.2 [skip ci] * chore: release @cypress/vite-dev-server-v5.0.3 [skip ci] * chore: Update v8 snapshot cache (#25822) Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <[email protected]> * feat: support host only cookies (#25853) * feat: allow setCookie API to take a hostOnly option * chore: add jsdoc/typescript description to render to users * chore: add changelog entry * [run ci] * chore: fix types * chore: fix cookie login tests * chore: update e2e cookie system tests * [run ci] * chore: fix cookie command tests. localhost cookies are calculated as hostOnly, which is consistent with how cypress works today * chore: fix system tests for cookies. * [run ci] * chore: fix system tests * chore: skip hostOnly assertions in webkit (for now) * [run ci] * chore: add property definitions to setCookieOptions * [run ci] * chore: add comments to hostOnly prop in firefox when setting a cookie * fix(webpack-dev-server): touch component-index during onSpecsChange to avoid writing to app file (#25861) * testing: try disabling uTimesSync and see what happens * build binaries [run ci] * fix: touch component index file instead of browser.js * build binaries [run ci] * update test * fix test * add test for custom HTML file in config * use existing component index in webpack-dev-server unit tests --------- Co-authored-by: Lachlan Miller <[email protected]> * chore: release @cypress/webpack-dev-server-v3.2.4 [skip ci] * chore: improve types for server automation cookie client (#25836) * chore: improve types for automation cookies * [run ci] * fix: the cookie_behavior tests by syncing cookies immediately if … (#25855) * fix: fix the cookie_behavior tests by syncing cookies immediately if the application is already stable * chore: add changelog entry * [run ci] * chore: address comments from code review * feat: Public API for CT Framework Definitions (#25780) * chore: rework component onboarding in launchpad (#25713) * chore: refactoring and types * rework source of frameworks * revert rename * fix tests * fix more tests * types * update code * use same public API internally * rename interfaces * rename * work on dev server api * fix types * fix test * attempt to support getDevServerConfig * tests * add function to define framework [skip ci] * rework a lot of types * fix test * update tests and types * refactor * revert changes * lint * fix test * revert * remove * add "community" label [skip ci] * refactor * types * lint * fix bug * update function name * address feedback * improve types with Pick * refactor using type guard * correct label --------- Co-authored-by: Zachary Williams <[email protected]> * chore: typing error * feat: scan for 3rd party ct plugins (#25749) * chore: refactoring and types * rework source of frameworks * revert rename * fix tests * fix more tests * types * update code * use same public API internally * rename interfaces * rename * work on dev server api * fix types * fix test * attempt to support getDevServerConfig * tests * add function to define framework [skip ci] * rework a lot of types * fix test * update tests and types * refactor * revert changes * lint * fix test * revert * remove * add "community" label [skip ci] * refactor * types * lint * fix bug * update function name * address feedback * feat: scan for 3rd party ct plugins * add e2e test * unit tests [run ci] * tweak resolution * rebase, address comments * fix windows paths * remove .gitignore * fix test --------- Co-authored-by: Lachlan Miller <[email protected]> * lint config * spacing * try fix race cond * fix import error * build binary * try update snapshot * try using require * support namespaced definitions (#25804) * remove category * add icon prop * support esm -> cjs compiled typescript * fix test * misc: add CTA footer to launchpad framework dropdown (#25831) * remove test project dependencies * rebase * windows * windows again * add changelog entry * changelog * revert workflow * remove worklfow --------- Co-authored-by: Zachary Williams <[email protected]> Co-authored-by: Adam Stone-Lord <[email protected]> * chore: release @cypress/webpack-dev-server-v3.3.0 [skip ci] * fix: Add missing error message when `req.continue` is used incorrectly (#25884) --------- Co-authored-by: Adam Stone-Lord <[email protected]> Co-authored-by: Zachary Williams <[email protected]> Co-authored-by: Mike Plummer <[email protected]> Co-authored-by: Matt Schile <[email protected]> Co-authored-by: Alejandro Estrada <[email protected]> Co-authored-by: Emily Rohrbough <[email protected]> Co-authored-by: Ryan Pei <[email protected]> Co-authored-by: Emily Rohrbough <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: cypress-bot[bot] <2f0651858c6e38e0+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Ryan Manuel <[email protected]> Co-authored-by: cypress-bot[bot] <47117332+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Mark Noonan <[email protected]> Co-authored-by: Stokes Player <[email protected]> Co-authored-by: Chris Breiding <[email protected]> Co-authored-by: Zach Bloomquist <[email protected]> Co-authored-by: willmsC <[email protected]> Co-authored-by: Zach Bloomquist <[email protected]> Co-authored-by: cypress-bot[bot] <+cypress-bot[bot]@users.noreply.github.com> Co-authored-by: Tim Griesser <[email protected]> Co-authored-by: Matt Henkes <[email protected]> Co-authored-by: semantic-release-bot <[email protected]> Co-authored-by: Ben M <[email protected]> Co-authored-by: Bill Glesias <[email protected]> Co-authored-by: Podles <[email protected]> Co-authored-by: Paolo Caleffi <[email protected]> Co-authored-by: Lachlan Miller <[email protected]>

Update workflows.yml

7939cf9

emilyrohrbough reviewed Feb 13, 2023

View reviewed changes

ryanthemanuel added 2 commits February 13, 2023 09:45

Update update_v8_snapshot_cache.yml

322873a

Update workflows.yml

4fcc2ef

ryanthemanuel added 2 commits February 13, 2023 10:29

Update update_v8_snapshot_cache.yml

ab80654

Update update_v8_snapshot_cache.yml

659e9a6

ryanthemanuel commented Feb 13, 2023

View reviewed changes

.github/workflows/update_v8_snapshot_cache.yml Outdated Show resolved Hide resolved

ryanthemanuel and others added 5 commits February 13, 2023 10:46

Update .github/workflows/update_v8_snapshot_cache.yml

b75f43a

Update snapshot-meta.json

3ef8ad1

chore: updating v8 snapshot cache

1ec336e

Merge branch 'develop' into ryanthemanuel-patch-2

aaf3b6d

Update update-browser-versions.yml

393f252

emilyrohrbough reviewed Feb 13, 2023

View reviewed changes

mjhenkes reviewed Feb 13, 2023

View reviewed changes

Update update_v8_snapshot_cache.yml

ca7a4be

mjhenkes approved these changes Feb 13, 2023

View reviewed changes

emilyrohrbough approved these changes Feb 13, 2023

View reviewed changes

ryanthemanuel added 4 commits February 13, 2023 14:19

Merge branch 'develop' into ryanthemanuel-patch-2

0144ba7

Merge branch 'develop' into ryanthemanuel-patch-2

8377085

Update workflows.yml

915bfb2

Merge branch 'develop' into ryanthemanuel-patch-2

99fc2bb

ryanthemanuel merged commit eed2b84 into develop Feb 14, 2023

ryanthemanuel deleted the ryanthemanuel-patch-2 branch February 14, 2023 21:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: update workflows.yml to include the v8 snapshot update branch #25784

chore: update workflows.yml to include the v8 snapshot update branch #25784

ryanthemanuel commented Feb 13, 2023 •

edited

Loading

emilyrohrbough Feb 13, 2023

ryanthemanuel Feb 13, 2023

cypress bot commented Feb 13, 2023 •

edited

Loading

emilyrohrbough Feb 13, 2023

mjhenkes Feb 13, 2023

ryanthemanuel Feb 13, 2023

mjhenkes Feb 13, 2023

ryanthemanuel Feb 13, 2023

chore: update workflows.yml to include the v8 snapshot update branch #25784

chore: update workflows.yml to include the v8 snapshot update branch #25784

Conversation

ryanthemanuel commented Feb 13, 2023 • edited Loading

Additional details

Steps to test

How has the user experience changed?

PR Tasks

emilyrohrbough Feb 13, 2023

Choose a reason for hiding this comment

ryanthemanuel Feb 13, 2023

Choose a reason for hiding this comment

cypress bot commented Feb 13, 2023 • edited Loading

40 flaky tests on run #44087 ↗︎

emilyrohrbough Feb 13, 2023

Choose a reason for hiding this comment

mjhenkes Feb 13, 2023

Choose a reason for hiding this comment

ryanthemanuel Feb 13, 2023

Choose a reason for hiding this comment

mjhenkes Feb 13, 2023

Choose a reason for hiding this comment

ryanthemanuel Feb 13, 2023

Choose a reason for hiding this comment

ryanthemanuel commented Feb 13, 2023 •

edited

Loading

cypress bot commented Feb 13, 2023 •

edited

Loading