Code

fix: duplicate and expired cookies#25761

Code

Merged

AtofStryker merged 47 commits intodevelopcypress-io/cypress:developfrom fix-duplicate-and-expired-cookiescypress-io/cypress:fix-duplicate-and-expired-cookiesCopy head branch name to clipboardFeb 16, 2023

+336-12

Commits

Commits on Feb 9, 2023

• chore: add regression tests for duplicate cookies and bad expiry times

  AtofStryker

  committed
  d13c0f6

• avoid prepending domain with dot for cookies that are set with the server side jar. This is to avoid the cookie being duplicated if it is set or overridden in a different context (request that can …

  Show description for 2b97638
  AtofStryker

  committed
  2b97638

• feat: use cookie.toString() in the cookie patch to more accurately set cookies on the document, which should include other properties besides key=value

  AtofStryker

  committed
  9b6db60

• fix: add logic to handle expired cookies in the document.cookie patch, as well as in CDP

  AtofStryker

  committed
  3a05675

• chore: build binary for cookie fixes for users to test

  AtofStryker

  committed
  27c6076

• chore: change name of fixture to something more accurate

  AtofStryker

  committed
  70b709c

• chore: comment why we are using the toughCookie toString method in the patch

  AtofStryker

  committed
  91c3c7c

• [run ci]

  AtofStryker

  committed
  dcdb11c

• chore: add changelog entry

  AtofStryker

  committed
  844c831

• Merge branch 'develop' of github.com:cypress-io/cypress into fix-duplicate-and-expired-cookies

  AtofStryker

  committed
  bd62d4f

• [run ci]

  AtofStryker

  committed
  38a65a6

Commits on Feb 13, 2023

• Merge branch 'develop' of github.com:cypress-io/cypress into fix-duplicate-and-expired-cookies

  AtofStryker

  committed
  7b90551

• fix: revert back to key=value when getting document.cookie as those are the only values are displayed (oversight on my end)

  AtofStryker

  committed
  4a9cfb5

• [run ci]

  AtofStryker

  committed
  8927a3c

• chore: make compatible with cypress.require

  AtofStryker

  committed
  864baff

• fix: add tests for hostOnly/non hostOnly cookies to make sure property gets sent up to automation client correctly. No longer need custom cookie prop to determine destination

  AtofStryker

  committed
  868c52c

• Merge branch 'develop' of github.com:cypress-io/cypress into fix-duplicate-and-expired-cookies

  AtofStryker

  committed
  0d0dbd6

• [run ci]

  AtofStryker

  committed
  f545ab1

• fix: stale unit test

  AtofStryker

  committed
  5b0a9bf

• chore: adjust comments

  AtofStryker

  committed
  ea31a02

• [run ci]

  AtofStryker

  committed
  b93ce75

• fix: bad domain logic

  AtofStryker

  committed
  48b9550

• [run ci]

  AtofStryker

  committed
  2df76b7

• chore: remove irrelevant comment

  AtofStryker

  committed
  3431437

• [run ci]

  AtofStryker

  committed
  c1d8360

Commits on Feb 14, 2023

• fix: adjust cookie login text to spec hostOnly cookie within the cookie patch. This should yield the same behavior as we are bound to same origin within the spec bridge

  AtofStryker

  committed
  22c46f3

• [run ci]

  AtofStryker

  committed
  fd23fb1

• Merge branch 'develop' of github.com:cypress-io/cypress into fix-duplicate-and-expired-cookies

  AtofStryker

  committed
  913e317

• [run ci]

  AtofStryker

  committed
  331dd69

• fix: allow for cookies on request of same key to take precedence over cookies in the jar, regardless of how many hierachy cookies exist in the jar

  AtofStryker

  committed
  17de188

• chore: fix cookie misc tests for cy.origin (dont run cy.origin)

  AtofStryker

  committed
  c3c1088

• [run ci]

  AtofStryker

  committed
  d44b202

• chore: skip misc cookie tests in webkit as headless behavior doesn't clear cookies between tests correctly

  AtofStryker

  committed
  173bda0

• Revert "fix: allow for cookies on request of same key to take precedence over cookies in the jar, regardless of how many hierachy cookies exist in the jar"

  Show description for dca9773
  AtofStryker

  committed
  dca9773

• [run ci]

  AtofStryker

  committed
  86a8cd8

Commits on Feb 15, 2023

• Merge branch 'develop' of github.com:cypress-io/cypress into fix-duplicate-and-expired-cookies

  AtofStryker

  committed
  ea29a59

• chore: split changelog entry into two parts

  AtofStryker

  committed
  4352ef5

• chore: update logic to remove else statement and add comments

  AtofStryker

  committed
  a67c06d

• Merge branch 'develop' of github.com:cypress-io/cypress into fix-duplicate-and-expired-cookies

  AtofStryker

  committed
  dff7db1

• [run ci]

  AtofStryker

  committed
  6106b1f

• chore: readd windows snapshot branch in workflows

  AtofStryker

  committed
  0b9e237

• [run ci]

  AtofStryker

  committed
  95589fd

• chore: fix workflows from bad merge

  AtofStryker

  committed
  ef902f1

• [run ci]

  AtofStryker

  committed
  d5a2876

Commits on Feb 16, 2023

• Merge branch 'develop' of github.com:cypress-io/cypress into fix-duplicate-and-expired-cookies

  AtofStryker

  committed
  3a676ab

• Revert "chore: split changelog entry into two parts"

  Show description for 8567812
  AtofStryker

  committed
  8567812

• [run ci]

  AtofStryker

  committed
  3ec78f1