Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: export types #25714

Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix: export types #25714

merged 1 commit into from
Feb 7, 2023

Conversation

lmiller1990
Copy link
Contributor

Additional details

Export types.

Steps to test

No real need. You could pull the branch, build, and sure types are exported.

How has the user experience changed?

N/A

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@lmiller1990 lmiller1990 requested a review from a team February 6, 2023 01:41
@lmiller1990 lmiller1990 mentioned this pull request Feb 6, 2023
Closed
@cypress
Copy link

cypress bot commented Feb 6, 2023 •
edited
Loading

Passing run #43849 ↗︎

0 565 0 0 Flakiness 0

Details:

chore: export types
Project: cypress Commit: 41b692856a
Status: Passed Duration: 07:30 💡
Started: Feb 6, 2023 10:39 PM Ended: Feb 6, 2023 10:47 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mike-plummer mike-plummer requested a review from a team February 6, 2023 13:54
@emilyrohrbough
Copy link
Member

@lmiller1990 Isn't this a bug fix? Would need type fix to trigger a patch release with this change.

@lmiller1990 lmiller1990 changed the title chore: export types fix: export types Feb 6, 2023
@lmiller1990
Copy link
Contributor Author

@emilyrohrbough sure, good point - I changed it to fix.

@lmiller1990 lmiller1990 changed the base branch from develop to master February 6, 2023 23:25
@lmiller1990 lmiller1990 changed the base branch from master to develop February 6, 2023 23:25
@lmiller1990 lmiller1990 merged commit 1a9bc2c into develop Feb 7, 2023
@lmiller1990 lmiller1990 deleted the issue/25705 branch February 7, 2023 08:02
@samtjo
Copy link

samtjo commented Feb 7, 2023

Hey @lmiller1990 @emilyrohrbough - This doesn't look like it triggered a release, it would normally be the commit message that should have type fix rather than the PR title, although obviously I don't work at Cypress and haven't looked in depth at your setup.

So just checking, is there a way you can manually trigger a release for this or will we have to wait until the next release is triggered by something else?

Thanks!

@mike-plummer
Copy link
Contributor

Hey @lmiller1990 @emilyrohrbough - This doesn't look like it triggered a release, it would normally be the commit message that should have type fix rather than the PR title, although obviously I don't work at Cypress and haven't looked in depth at your setup.

So just checking, is there a way you can manually trigger a release for this or will we have to wait until the next release is triggered by something else?

Thanks!

Hi @samtjo . We run on a ~2 week release cadence, so this fix should be included in our 12.6.0 release currently planned for a week from today

@samtjo
Copy link

samtjo commented Feb 7, 2023

Great thanks @mike-plummer!

@lmiller1990
Copy link
Contributor Author

It's also possible to trigger a release by making a PR directly against master - I should have done that. If you want this feature now you could

  1. fork master
  2. cherry-pick this commit
  3. make a PR against master
  4. when merged, semantic release runs

Alternatively, just wait for the next release. 💯

@samtjo
Copy link

samtjo commented Feb 8, 2023

It's alright, I can wait until next week for 12.6.0 - thanks again 👍🏻

@ZachJW34
Copy link
Contributor

ZachJW34 commented Feb 8, 2023

@lmiller1990 @samtjo master is no longer used for releasing npm packages. Develop merges will now kick off semantic-release if applicable. This package should be released come the next green develop merge (though looks like develop is struggling to go green). Note that the update would only apply to @cypress/react (downloaded via npm), the cypress/react package only updates per Cypress release

@samtjo
Copy link

samtjo commented Feb 8, 2023 •
edited
Loading

Just to check @ZachJW34, is the next Cypress release you're referring to, the 12.6.0 one next week?

@ZachJW34
Copy link
Contributor

ZachJW34 commented Feb 8, 2023

@samtjo Yes that's the one!

tgriesser added a commit that referenced this pull request Feb 8, 2023
@tgriesser
Merge branch 'develop' into tgriesser/spike/spike
bdce6fe 
* develop: (28 commits)
  chore: update changelog validation example (#25742)
  fix: Improve error handling around calls to `this.next` in middleware (#25702)
  chore: debug page tooltip distance and artifact border (#25727)
  fix: update newProject ref when switching between organizations in SelectCloudProjectModal (#25730)
  misc: Add max widths to debug page message states (#25725)
  chore: export types (#25714)
  chore: release @cypress/webpack-preprocessor-v5.16.3
  chore: release @cypress/vue-v5.0.4
  chore: release @cypress/grep-v3.1.4
  chore: Fix flaky test (#25726)
  dependency(deps): update dependency debug to ^4.3.4 🌟 (#25699)
  feat: openInIDE for failed debug spec (#25691)
  test: fix flaky CT test by relying on query (#25706)
  test: fix flaky migration test (#25672)
  misc: style change for responsiveness (#25687)
  misc: set min widths for icons (#25684)
  chore(deps): update dependency markdown-it to v11.0.1 🌟 (#25698)
  chore: Fix flaky origin .wait() test (#25693)
  chore: unskip tests (#25676)
  chore: release @cypress/webpack-preprocessor-v5.16.2
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samtjo samtjo samtjo approved these changes

@mike-plummer mike-plummer mike-plummer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MountOptions and MountReturn interfaces not exported from cypress/react18
5 participants
@lmiller1990 @emilyrohrbough @samtjo @mike-plummer @ZachJW34