Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: improve debug loading text wrap responsiveness #25703

Merged
merged 6 commits into from
Feb 8, 2023
+15 −12
Merged

misc: improve debug loading text wrap responsiveness #25703

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
13dbd41
misc: improve debug loading text wrap responsiveness
ZachJW34 Feb 3, 2023
e6a78f8
add changelog entry
ZachJW34 Feb 3, 2023
2b7c1a0
Merge branch 'develop' into zachw/debug-loading-text-wrap
ZachJW34 Feb 3, 2023
e8cebba
Merge branch 'develop' into zachw/debug-loading-text-wrap
ZachJW34 Feb 6, 2023
09ed01b
Merge branch 'develop' into zachw/debug-loading-text-wrap
ZachJW34 Feb 7, 2023
5d2f16b
Merge branch 'develop' into zachw/debug-loading-text-wrap
ZachJW34 Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ _Released 02/14/2023 (PENDING)_

- Improved the layout of the Debug Page on smaller viewports when there is a pending run. Addresses [#25664](https://github.com/cypress-io/cypress/issues/25664).
- Icons in Debug page will no longer shrink at small viewports. Addresses [#25665](https://github.com/cypress-io/cypress/issues/25665).
- Improved the layout of the Debug Page empty states on smaller viewports. Addressed in [#25703](https://github.com/cypress-io/cypress/pull/25703).

**Dependency Updates:**

Expand Down
4 changes: 4 additions & 0 deletions packages/app/src/debug/empty/DebugEmptyStates.cy.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,10 @@ describe('Debug page empty states', () => {
cy.findByRole('link', { name: 'Learn about project setup in Cypress' }).should('have.attr', 'href', 'https://on.cypress.io/adding-new-project?utm_source=Binary%3A+Launchpad&utm_medium=Debug+Tab&utm_campaign=Learn+More')

cy.percySnapshot()

cy.viewport(600, 600)

cy.percySnapshot('responsive')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing this snapshot in the Percy build for some reason 🤔

})
})

Expand Down
22 changes: 10 additions & 12 deletions packages/app/src/debug/empty/DebugEmptyView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,18 +24,16 @@
:rows="loadingRows"
>
<template #header>
<div class="bg-white border rounded-md flex border-gray-100 w-max p-5px text-14px text-gray-700">
<div><i-cy-status-failed_x12 /></div>
<div class="bg-gray-700 h-1px mx-5px mt-7px w-5px" />
<div
v-if="exampleTestName"
class="bg-gray-100 h-13px mx-1 pb-1px w-1px"
/>
<div
v-if="exampleTestName"
class="mx-1 text-14px text-gray-700"
>
{{ exampleTestName }}
<div class="flex">
<div class="bg-white border rounded-md flex border-gray-100 py-4px px-8px text-14px text-gray-700 gap-8px items-center">
<i-cy-status-failed_x12 class="h-12px w-12px" />
<span>-</span>
<div
v-if="exampleTestName"
class="border-l border-gray-100 pl-8px"
>
{{ exampleTestName }}
</div>
</div>
</div>
</template>
Expand Down