Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CYPRESS_DOWNLOAD_PATH_TEMPLATE placeholder #25531

Merged
merged 8 commits into from
May 5, 2023

Conversation

mahdikhashan
Copy link
Contributor

@mahdikhashan mahdikhashan commented Jan 20, 2023

User facing changelog

Additional details

Steps to test

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2023

CLA assistant check
All committers have signed the CLA.

@alex1701c
Copy link

@mahdikhashan Any update on this? I would really like this to get in :)

@mahdikhashan
Copy link
Contributor Author

@alex1701c There have been an issue with it, other non-related tests are failing. Will give it a shot tomorrow in my spare time, hopefully will be fixed and people can merge it.

@alex1701c
Copy link

@mahdikhashan Any update?

@mahdikhashan
Copy link
Contributor Author

mahdikhashan commented May 4, 2023

@alex1701c it should be fixed now.

@mahdikhashan mahdikhashan marked this pull request as ready for review May 4, 2023 12:39
@alex1701c
Copy link

Thanks a lot! Let's hope this can get merged soonish 😄

@cypress
Copy link

cypress bot commented May 4, 2023

30 flaky tests on run #46043 ↗︎

0 27269 1307 0 Flakiness 30

Details:

Apply suggestions from code review
Project: cypress Commit: f6fc0dd8e2
Status: Passed Duration: 20:40 💡
Started: May 5, 2023 3:41 PM Ended: May 5, 2023 4:01 PM
Flakiness  commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-electron

View Output Video

Test Artifacts
network stubbing > intercepting request > can delay and throttle a StaticResponse Output Video
Flakiness  cypress/cypress.cy.js • 3 flaky tests • 5x-driver-electron

View Output Video

Test Artifacts
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
... > correctly returns currentRetry Output Video
Flakiness  create-from-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress-in-cypress-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress CT > default config > redirects to the specs list with error if a spec is not found Output Screenshots Video

The first 5 flaky specs are shown, see all 17 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

cli/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Matt Schile <[email protected]>
@mschile mschile requested review from AtofStryker and ryanthemanuel and removed request for AtofStryker May 5, 2023 01:07
@mahdikhashan mahdikhashan requested a review from mschile May 5, 2023 08:22
@mschile mschile merged commit 63be85f into cypress-io:develop May 5, 2023
@mschile
Copy link
Contributor

mschile commented May 5, 2023

Thanks for the contribution @mahdikhashan 🎉

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 12, 2023

Released in 12.12.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.12.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CYPRESS_DOWNLOAD_PATH_TEMPLATE only replace placeholder once
6 participants