chore: Bump version, update example project dependency. #25003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
mjhenkes
commented
Dec 6, 2022
packages/example/package.json
Outdated
| "dependencies": { | ||
| "bluebird": "3.5.3", | ||
| "glob": "7.1.3" | ||
| }, | ||
| "devDependencies": { | ||
| "chai": "3.5.0", | ||
| "cross-env": "6.0.3", | ||
| "cypress-example-kitchensink": "https://github.com/cypress-io/cypress-example-kitchensink.git#994a943b76f1186c10ce083f48266cee2f76aeb4", | ||
| "cypress-example-kitchensink": "https://github.com/cypress-io/cypress-example-kitchensink.git#bd93f68568bc0a412b2c4dd2ddbc3b7cb89e5799", |
There was a problem hiding this comment.
crumbs, do i need to release a 12.0.1 for this?
There was a problem hiding this comment.
I don't think so. its a dev dependencies & isn't shipped with the examples.
There was a problem hiding this comment.
It is what scaffolds the kitchensink tests when e2e tests are scaffolded, so it is shipped.
There was a problem hiding this comment.
Why is it a dev dependency?
There was a problem hiding this comment.
Why is this in devDeps though. 🤔
emilyrohrbough
approved these changes
Dec 6, 2022
AtofStryker
approved these changes
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
N/A
Additional details
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?