fix(grep): update cypress-grep references & docs & add e2e tests #24992

jordanpowell88 · 2022-12-06T14:03:22Z

Closes @cypress/grep internal read.me is correct - NPM references deprecated cypress-grep package #24967
Closes @cypress/grep readme references previous cypress-grep package #24696
Closes @cypress/grep cannot find module cypress-grep or it's corresponding type declarations #24512

User facing changelog

fix references still pointing to cypress-grep

Additional details

This PR also adds e2e tests as part of this lib

Steps to test

yarn workspace @cypress/grep test // unit tests
yarn workspace @cypress/grep cy:run // e2e tests

How has the user experience changed?

PR Tasks

Have tests been added/updated?
Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
Has a PR for user-facing changes been opened in cypress-documentation?
Have API changes been updated in the type definitions?

cypress-bot · 2022-12-06T14:03:25Z

Thanks for taking the time to open a PR!

Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

cypress · 2022-12-06T15:05:40Z

47 flaky tests on run #43567 ↗︎

0	26600	1274	0	47

Details:

chore: update grep test command
Project: cypress	Commit: `b57a19684c`
Status: Passed	Duration: 19:37 💡
Started: Jan 30, 2023 3:02 PM	Ended: Jan 30, 2023 3:22 PM

commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test
network stubbing > intercepting request > can delay and throttle a StaticResponse

e2e/origin/commands/navigation.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test
cy.origin navigation > #consoleProps > .go()

e2e/origin/commands/waiting.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test
cy.origin waiting > alias > waits for the route alias to have a response

e2e/origin/config_env.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test
cy.origin- Cypress.config() > serializable > overwrites different values in secondary if one exists in the primary

e2e/origin/commands/assertions.cy.ts • 1 flaky test • 5x-driver-firefox

View Output Video

Test
cy.origin assertions > #consoleProps > .should() and .and()

The first 5 flaky specs are shown, see all 25 specs in Cypress Cloud.

_{This comment has been generated by cypress-bot as a result of this
project's GitHub integration settings.}

npm/grep/cypress/support/commands.js

jaffrepaul

Left one comment about addAxeCode.

Didn't have the bandwidth to test run this, but otherwise looks straight forward.

npm/grep/scripts.js

npm/grep/package.json

jordanpowell88 · 2022-12-09T18:45:37Z

I updated to using system-tests using the strategy @ZachJW34 implemented on @cypress/schematic

emilyrohrbough · 2022-12-09T18:47:44Z

system-tests/projects/grep/package.json

+  "name": "grep",
+  "version": "0.0.0",
+  "devDependencies": {
+    "cypress": "latest",


We shouldn't be installing Cypress but testing against the binary.

emilyrohrbough · 2022-12-09T18:50:58Z

npm/grep/test.spec.js

+  it('run Unit Tests', async () => {
+    await runCommandInProject('npx cypress run --spec cypress/e2e/unit.js --config specPattern="**/unit.js"', projectPath)
+  })


there should not be unit tests in system-tests. These should live in npm/grep

emilyrohrbough · 2022-12-09T18:57:07Z

npm/grep/test.spec.js

+    await runCommandInProject(`npx cypress-expect --min-passing 5 --pending 0`, projectPath)
+  })
+
+  it('Run e2e skip tests without grep 🧪', async () => {


I would expect these system tests to be modeled like the other system-tests in Cypress for maintainability purposes. If we need to make enhancements to support checking the report output, I think that'd be better than adding dozens of json files with the test results don't live with the test. At a min, this need to be running against the binary and not using npx in these tests.

The issue is that the plugin needs the cypress module, and it can't resolve without it. It is the same issue we have with @cypress/schematics. This is why we have to move the system tests to a temp dir to run

@jordanpowell88 What do you mean exactly? Because it's listed as a peerDependency?

Yes it needs cypress as a peerDep but it also needs cypress as a devDep

Looking how this is setup though, that's because of cypress-expect right? which I why I am wondering if that's the right tool if we are unable to setup the system-tests to use the just-built binary. It looks like this is just a wrapper around running cypress programmatically to return the test results. We can pull the cypress output from systemTests.it to determine the tests that ran and how many passed & failed.

Correct, we can do this but this would be a bigger lift than we are wanting to do at this moment

lmiller1990 · 2022-12-16T00:05:53Z

@jordanpowell88 and you re-ping when this is ready to review? 🙏

Narretz · 2023-01-30T12:21:41Z

Are there any updates for this @jordanpowell88 ?

Narretz · 2023-02-27T17:31:21Z

Hi @jordanpowell88 I hate to be that person, but is there any news here?

Narretz · 2023-03-07T20:57:52Z

Hi @jordanpowell88 I go the notification that this issue is closed, but the code hasn't been merged. Will the work continue in another PR?

lmiller1990 · 2023-03-08T23:18:21Z

Let me find out for you. We should decide what's happening with cypress-grep moving forward.

jordanpowell88 · 2023-03-14T17:41:15Z

@Narretz re-opened this PR (without the tests) #26108

Narretz · 2023-03-14T22:31:50Z

Thanks @jordanpowell88

What's with the tests, though? Will they be added in a separate PR?

jordanpowell88 · 2023-03-15T13:17:23Z

This will be up the @cypress-io/end-to-end team to create a follow issue around this as they are now responsible for handling the @cypress/grep package. Feel free to create an issue as well

jordanpowell88 force-pushed the jordanpowell88/update-grep branch from 7f1e4ec to a672f8f Compare December 6, 2022 14:29

jordanpowell88 requested a review from a team December 6, 2022 19:30

jordanpowell88 force-pushed the jordanpowell88/update-grep branch from 72b8fe3 to bfd2944 Compare December 6, 2022 19:52

jordanpowell88 mentioned this pull request Dec 6, 2022

feat: make grepFilterSpecs work with negative grep #24861

Closed

4 tasks

jaffrepaul reviewed Dec 6, 2022

View reviewed changes

npm/grep/cypress/support/commands.js Outdated Show resolved Hide resolved

jaffrepaul reviewed Dec 6, 2022

View reviewed changes

jordanpowell88 requested a review from jaffrepaul December 6, 2022 20:45

emilyrohrbough reviewed Dec 6, 2022

View reviewed changes

npm/grep/scripts.js Outdated Show resolved Hide resolved

jennifer-shehane reviewed Dec 6, 2022

View reviewed changes

npm/grep/package.json Show resolved Hide resolved

jordanpowell88 force-pushed the jordanpowell88/update-grep branch from e7e0f12 to 71ee31b Compare December 9, 2022 17:10

jordanpowell88 requested review from emilyrohrbough, jennifer-shehane and ZachJW34 December 9, 2022 18:44

jordanpowell88 force-pushed the jordanpowell88/update-grep branch from 00d9cc4 to 0aeb3f1 Compare December 9, 2022 18:53

emilyrohrbough requested changes Dec 9, 2022

View reviewed changes

jordanpowell88 force-pushed the jordanpowell88/update-grep branch 2 times, most recently from 3a225d0 to daa400d Compare December 13, 2022 14:56

jordanpowell88 added 8 commits January 30, 2023 09:01

fix(grep): update cypress-grep references & docs & add e2e tests

6cb18c0

chore: add xpath & grep to CI

0b98384

chore: add install cypress step to grep

130a6b1

chore: update working dir

6cfd0a9

chore: remove axe command

bdf46ca

test(grep): move tests to system-tests

fd41a99

test(grep): add unit tests

9e4a577

test(grep): remove system tests

c502d86

jordanpowell88 force-pushed the jordanpowell88/update-grep branch from 7e45cf4 to c502d86 Compare January 30, 2023 14:02

jordanpowell88 added 2 commits January 30, 2023 09:50

chore: update grep test command

b57a196

Merge branch 'develop' into jordanpowell88/update-grep

e27dd90

jennifer-shehane removed request for jennifer-shehane, jaffrepaul and ZachJW34 March 1, 2023 14:38

jordanpowell88 closed this Mar 7, 2023

jordanpowell88 mentioned this pull request Mar 14, 2023

fix(grep): references to cypress-grep #26108

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(grep): update cypress-grep references & docs & add e2e tests #24992

fix(grep): update cypress-grep references & docs & add e2e tests #24992

jordanpowell88 commented Dec 6, 2022 •

edited by emilyrohrbough

Loading

cypress-bot bot commented Dec 6, 2022

cypress bot commented Dec 6, 2022 •

edited

Loading

jaffrepaul left a comment

jordanpowell88 commented Dec 9, 2022

emilyrohrbough Dec 9, 2022

emilyrohrbough Dec 9, 2022

jordanpowell88 Dec 14, 2022

emilyrohrbough Dec 9, 2022

jordanpowell88 Dec 9, 2022

emilyrohrbough Dec 9, 2022

jordanpowell88 Dec 9, 2022

emilyrohrbough Dec 9, 2022

jordanpowell88 Dec 14, 2022

lmiller1990 commented Dec 16, 2022

Narretz commented Jan 30, 2023

Narretz commented Feb 27, 2023

Narretz commented Mar 7, 2023

lmiller1990 commented Mar 8, 2023 •

edited

Loading

jordanpowell88 commented Mar 14, 2023

Narretz commented Mar 14, 2023 •

edited

Loading

jordanpowell88 commented Mar 15, 2023 •

edited

Loading

fix(grep): update cypress-grep references & docs & add e2e tests #24992

fix(grep): update cypress-grep references & docs & add e2e tests #24992

Conversation

jordanpowell88 commented Dec 6, 2022 • edited by emilyrohrbough Loading

User facing changelog

Additional details

Steps to test

How has the user experience changed?

PR Tasks

cypress-bot bot commented Dec 6, 2022

cypress bot commented Dec 6, 2022 • edited Loading

47 flaky tests on run #43567 ↗︎

jaffrepaul left a comment

Choose a reason for hiding this comment

jordanpowell88 commented Dec 9, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lmiller1990 commented Dec 16, 2022

Narretz commented Jan 30, 2023

Narretz commented Feb 27, 2023

Narretz commented Mar 7, 2023

lmiller1990 commented Mar 8, 2023 • edited Loading

jordanpowell88 commented Mar 14, 2023

Narretz commented Mar 14, 2023 • edited Loading

jordanpowell88 commented Mar 15, 2023 • edited Loading

jordanpowell88 commented Dec 6, 2022 •

edited by emilyrohrbough

Loading

cypress bot commented Dec 6, 2022 •

edited

Loading

lmiller1990 commented Mar 8, 2023 •

edited

Loading

Narretz commented Mar 14, 2023 •

edited

Loading

jordanpowell88 commented Mar 15, 2023 •

edited

Loading