fix: Change cy.end() back to a command instead of a query #24681
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
No user-facing changes.
Additional details
Fix for issue introduced as part of #24628.
We want .end() not to be a query. This is because:
cy.get('button').end().get('button')
should end with a subject chain of
[null, get('button')]
and not[get('button'), end(), get('button')]
. We want .end() to cut things off (which non-query commands do).Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
? Updated as part of the in-flight detached dom docs PR (Queries, Detached DOM, and Retry-Ability cypress-documentation#4835)type definitions
?