Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding solid component testing support #24587

Closed
wants to merge 1 commit into from

Conversation

cuixiaorui
Copy link

User facing changelog

Additional details

I refer to the PR

Implemented cypress component test support for solid

TODO

  1. No documentation written (similar to this document https://docs.cypress.io/guides/component-testing/quickstart-svelte#Configuring-Component-Testing)
  2. did not generate changelog (I do not know how to complete this operation, I hope someone can help me)

Steps to test

You can scaffold a new solid project with npm init vite and choose Solid. Then you can point yarn cypress:open at the solid project and get to testing!

There are also some system tests in system-tests/test/component_testing_spec.ts that test both webpack and vite.

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 8, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Nov 8, 2022

CLA assistant check
All committers have signed the CLA.

@nagash77 nagash77 added the CT Issue related to component testing label Nov 8, 2022
@marktnoonan
Copy link
Contributor

Hi @cuixiaorui, first, thank you for this PR. I'm going to close it without review, in light of this comment here: #24250 (comment) and @lmiller1990's comment here: #24494 (comment)

To summarize: we don't intend to add support for new frameworks to the core Cypress app in the short term. But we do intend to make it easier to write community-owned mount adapters that are as easy for users to adopt as the "officially" supported framework.

@lmiller1990
Copy link
Contributor

I am looking into a public API to let you support Solid (and other frameworks) directly in Cypress. Follow progress: #24991

@JessicaSachs
Copy link
Contributor

JessicaSachs commented Jan 19, 2023

@lmiller1990 or @baus is Solid still out of scope? I was literally about to make an issue/offer a PR when I saw there already was one! First class support for something that's topping the State of JS survey seems like a good move. 😄


I just asked a similar question of the Vite team about including it in their starter. They're probably going to have a "minimum number of npm downloads" stat as a metric on if they'll take on the maintenance burden. Seems like a reasonable approach to deciding if something will be 3rd party.

@baus
Copy link

baus commented Jan 19, 2023

@JessicaSachs It is on our roadmap to provide support for thirdparty framework implementations including documentation. We would like to use that to encourage support for Solid and other emerging frameworks.

@lmiller1990
Copy link
Contributor

I am working on letting third parties slot into launchpad/onboarding right now, I was thinking Solid a good first candidate for "how to plug into launchpad".

There are a few Solid mount adapters around, so you can definitely use CT with it already. There is also SolidStart - the meta framework for Solid, and that should also be pretty easy to support since it's just Vite under the hood.

@JessicaSachs
Copy link
Contributor

JessicaSachs commented Jan 20, 2023

Yeah, the ecosystem also is struggling with Storybook integration, so there's a clear need for a sandbox that enables component-driven development in the meantime.

LMK when I should take a look and I'll play around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CT Issue related to component testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solid Mount Support For Component Test
7 participants