-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding solid component testing support #24587
Conversation
Thanks for taking the time to open a PR!
|
Hi @cuixiaorui, first, thank you for this PR. I'm going to close it without review, in light of this comment here: #24250 (comment) and @lmiller1990's comment here: #24494 (comment) To summarize: we don't intend to add support for new frameworks to the core Cypress app in the short term. But we do intend to make it easier to write community-owned mount adapters that are as easy for users to adopt as the "officially" supported framework. |
I am looking into a public API to let you support Solid (and other frameworks) directly in Cypress. Follow progress: #24991 |
@lmiller1990 or @baus is Solid still out of scope? I was literally about to make an issue/offer a PR when I saw there already was one! First class support for something that's topping the State of JS survey seems like a good move. 😄 I just asked a similar question of the Vite team about including it in their starter. They're probably going to have a "minimum number of npm downloads" stat as a metric on if they'll take on the maintenance burden. Seems like a reasonable approach to deciding if something will be 3rd party. |
@JessicaSachs It is on our roadmap to provide support for thirdparty framework implementations including documentation. We would like to use that to encourage support for Solid and other emerging frameworks. |
I am working on letting third parties slot into launchpad/onboarding right now, I was thinking Solid a good first candidate for "how to plug into launchpad". There are a few Solid mount adapters around, so you can definitely use CT with it already. There is also SolidStart - the meta framework for Solid, and that should also be pretty easy to support since it's just Vite under the hood. |
Yeah, the ecosystem also is struggling with Storybook integration, so there's a clear need for a sandbox that enables component-driven development in the meantime. LMK when I should take a look and I'll play around. |
User facing changelog
Additional details
I refer to the PR
Implemented cypress component test support for solid
TODO
Steps to test
You can scaffold a new solid project with npm init vite and choose Solid. Then you can point yarn cypress:open at the solid project and get to testing!
There are also some system tests in system-tests/test/component_testing_spec.ts that test both webpack and vite.
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?