Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: patching packages in npm/webpack-preprocessor on windows builds #24473

Merged
merged 3 commits into from
Oct 31, 2022

Conversation

ryanthemanuel
Copy link
Collaborator

User facing changelog

n/a

Additional details

Windows builds are failing to yarn install failing on the post install step of npm/webpack-preprocessor. To fix this, we need to ensure that patch-package is not hoisted. Since public packages don't honor nohoist config, we have to set that config at the root level.

Steps to test

n/a

How has the user experience changed?

n/a

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 31, 2022

Thanks for taking the time to open a PR!

@chrisbreiding chrisbreiding self-requested a review October 31, 2022 19:52
@cypress
Copy link

cypress bot commented Oct 31, 2022



Test summary

584 6 36 15Flakiness 8


Run details

Project cypress
Status Failed
Commit 567a165
Started Oct 31, 2022 8:23 PM
Ended Oct 31, 2022 8:39 PM
Duration 16:21 💡
OS Windows 10.0.17763
Browser Chrome 107

View run in Cypress Dashboard ➡️


Failures

Run group: app-e2e (Windows, Chrome )
cypress\e2e\runs.cy.ts Failed
1 App: Runs > refetching > should re-query for executing runs
Run group: launchpad-e2e (Windows, Chrome )
cypress\e2e\migration.cy.ts Failed
1 Migrate custom config files > completes journey for migration-custom-config-file-respect-dirname
cypress\e2e\top-nav-launchpad.cy.ts Failed
1 ... > when there is a project id > if the project has no runs, shows "record your first run" prompt after clicking
cypress\e2e\scaffold-project.cy.ts Failed
1 scaffolding new projects > scaffolds E2E for a JS project
cypress\e2e\error-handling.cy.ts Failed
1 Error handling > it handles a config error
cypress\e2e\system-tests\config-spec.cy.ts Failed
1 config-spec > can filter browsers from config

Flakiness

cypress\e2e\runner\ct-framework-errors.cy.ts Flakiness
1 Nuxt > error conditions
cypress\e2e\specs.cy.ts Flakiness
1 ... > scaffold empty spec > should not show trouble rendering alert
cypress\e2e\scaffold-component-testing.cy.ts Flakiness
1 scaffolding component testing > vuecli4vue2 > scaffolds component testing for Vue CLI 4 w/ Vue 2 project
2 scaffolding component testing > svelte-vite-unconfigured > Scaffolds component testing for Svelte using vite
3 scaffolding component testing > svelte-webpack-unconfigured > Scaffolds component testing for Svelte using webpack
This comment includes only the first 5 flaky tests. See all 8 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ryanthemanuel ryanthemanuel merged commit 440a08b into develop Oct 31, 2022
@ryanthemanuel ryanthemanuel deleted the ryanm/fix/windows-node-module-install branch October 31, 2022 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants