fix: additionally set electron user agent through CDP #23721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
experimentalModifyObstructiveThirdPartyCode
option #23597User facing changelog
Additionally overrides the electron user agent via CDP if the userAgent config option is provided or
experimentalModifyObstructiveThirdPartyCode
is enabled.Additional details
It looks like the changes in #22958 did not fully override the electron user agent as expected (see #23597). In addition to setting the userAgent via the Electron's webContents.session API, we now optimistically set the user agent via CDP, which resolves the issue entirely.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?