Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip or fix flaky tests II #23386

Merged
merged 136 commits into from
Aug 22, 2022
Merged

Conversation

rachelruderman
Copy link
Contributor

@rachelruderman rachelruderman commented Aug 16, 2022

User facing changelog

N/A

Additional details

  1. Skip more flaky tests
  2. Update comments
  3. Fix Percy UI diffs - oversight missed in previous work

Steps to test

  1. Take a look at the job history. Confirm most of the last 10 builds succeeded (see link for definition). Note: do not rely on the GitHub check history since it will mark ❌ if any GitHub check fails, even optional ones. Some of the ❌ s are really ✅ for all the required checks. Flake in the dashboard that does not cause failure in CI is an example where we would see ❌ but consider the build ✅
  2. Confirm percy/cypress Github check succeeded consistently in Github Check history
  3. Confirm all skipped tests have a comment with a link to the GitHub issue logged for them

Note: to trigger another build, run:

  • git commit --allow-empty -m "Trigger Build"
  • git push

How has the user experience changed?

N/A

PR Tasks

  • Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 16, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Aug 16, 2022



Test summary

38883 0 4016 0Flakiness 0


Run details

Project cypress
Status Passed
Commit 0341a80
Started Aug 22, 2022 4:43 PM
Ended Aug 22, 2022 4:58 PM
Duration 14:30 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@rachelruderman rachelruderman marked this pull request as ready for review August 22, 2022 17:34
@rachelruderman rachelruderman merged commit ab23d77 into develop Aug 22, 2022
@rachelruderman rachelruderman deleted the skip-or-fix-flaky-tests-2 branch August 22, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants