chore: Update release guide docker steps #23249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes will test the docker image prior to making the new cypress release available. This will also ensure the docker image gets released very near to the npm package.
|
Thanks for taking the time to open a PR!
|
mjhenkes
commented
Aug 10, 2022
| @@ -136,28 +136,33 @@ In the following instructions, "X.Y.Z" is used to denote the [next version of Cy | |||
| - Merge any release-specific documentation changes into the main release PR. | |||
| - You can view the doc's [branch deploy preview](https://github.com/cypress-io/cypress-documentation/blob/master/CONTRIBUTING.md#pull-requests) by clicking 'Details' on the PR's `netlify-cypress-docs/deploy-preview` GitHub status check. | |||
|
|
|||
| 13. Make the new npm version the "latest" version by updating the dist-tag `latest` to point to the new version: | |||
| 13. Create a PR for a new docker image in [`cypress-docker-images`](https://github.com/cypress-io/cypress-docker-images) under `included` for the new cypress version. Note: we use the base image with the Node version matching the bundled Node version. Instructions for updating `cypress-docker-images` can be found [here](https://github.com/cypress-io/cypress-docker-images/blob/master/CONTRIBUTING.md#add-new-included-image). Ensure the docker image is reviewed and has passing tests before preceeding. | |||
There was a problem hiding this comment.
Moved creating the docker PR to be before we make the new tag 'latest'.
There was a problem hiding this comment.
Just curious, where do we find node version bundled with cypress?
There was a problem hiding this comment.
It's this: https://github.com/cypress-io/cypress/blob/develop/package.json#L220
It would be the version of node that electron ships.
There was a problem hiding this comment.
and we update the package.json whenever we update electron
mjhenkes
commented
Aug 10, 2022
mjhenkes
commented
Aug 10, 2022
|
|
||
| 16. If needed, deploy the updated [`cypress-example-kitchensink`][cypress-example-kitchensink] to `example.cypress.io` by following [these instructions under "Deployment"](../packages/example/README.md). | ||
| 17. Merge the new docker image PR created in step 13 to release the image. |
There was a problem hiding this comment.
Release the docker container here.
AtofStryker
approved these changes
Aug 10, 2022
emilyrohrbough
approved these changes
Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will test the docker image prior to making the new cypress release available. This will also ensure the docker image gets released very near to the npm package.
User facing changelog
n/a
Additional details
These changes will test the docker image prior to making the new cypress release available. This will also ensure the docker image gets released very near to the npm package.
Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?