-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: skip or fix flaky tests #23167
Merged
Merged
Changes from all commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
5d14498
skip 23162
rachelruderman 1a3ac28
skip 23101
rachelruderman 9e1319d
skip 23099
rachelruderman 111fc22
skip 23160, add comment
rachelruderman 1bc704a
skip 23159
rachelruderman 9e8da12
skip 23158
rachelruderman e704752
skip 23157
rachelruderman 7e0a41d
skip 23156
rachelruderman 85e5127
skip 23155
rachelruderman 426ea3b
skip 23154
rachelruderman 70921e9
skip 23153
rachelruderman db255e5
skip 23152
rachelruderman 73770c5
skip 23151
rachelruderman 445dcec
skip 23150
rachelruderman 600b94c
skip 23149
rachelruderman 3e1de0d
skip 23148
rachelruderman fa4fac9
Update net_stubbing.cy.ts
rachelruderman 521c501
skip 23100
rachelruderman 3e82dc8
skip 23201
rachelruderman c2d0f54
skip 23203
rachelruderman d05954c
Merge branch 'develop' into fix-or-skip-flaky-tests
rachelruderman 92ce06b
skip 23220
rachelruderman bec6359
update vscode comments
rachelruderman dfc55c4
Merge branch 'fix-or-skip-flaky-tests' of github.com:cypress-io/cypre…
rachelruderman cfdae38
skip 23245,23247,23246,23214
rachelruderman ee77ef7
skip 23248
rachelruderman 32fbdb6
skip 23250
rachelruderman b267d7c
add branch to circle.yml to allow testing on windows
rachelruderman f039462
skip 23252
rachelruderman 04a1362
Merge branch 'develop' into fix-or-skip-flaky-tests
rachelruderman 45f7c93
fix percy warnings and errors
rachelruderman 17d9a94
Update yarn.lock
rachelruderman 885d5bf
downgrade to percy/cli 1.2.0
rachelruderman 1cbc0a7
skip 23264
rachelruderman 0b6b4fa
fix addLog flake
rachelruderman 21ba76f
Add branch to mainBuildFilters
rachelruderman dd4ad70
percy version bump
rachelruderman cf20d11
Merge branch 'develop' into fix-or-skip-flaky-tests
rachelruderman 78ce539
use percy 1.2.0
rachelruderman 88e9ace
Fix error output 23248
rachelruderman 84b9e6d
fix 23145
rachelruderman 5396601
hopeful fix 23264
rachelruderman c3dc991
fix 23101
rachelruderman 3444562
fix 23150
rachelruderman 587760a
Fix 23160
rachelruderman a4adee9
Fix some flaky tests from 23150
rachelruderman 319b867
skip 23303
rachelruderman 3fa50d0
Merge branch 'develop' into fix-or-skip-flaky-tests
rachelruderman 2de35cf
Remove skip for 23248
rachelruderman 74a7f16
use var instead of done
rachelruderman f281b51
Fix "can delay with deprecated delayMs param"
rachelruderman f9cc637
skip 23305
rachelruderman 30ab403
skip 23306
rachelruderman c90fc9b
Add
rachelruderman 2a81bd8
Revert "Add"
rachelruderman ae153a0
fix diffs
rachelruderman 1eb489b
remove 10.0-release from branchesToAlwaysFinalize
rachelruderman 2554779
Merge branch 'develop' into fix-or-skip-flaky-tests
rachelruderman 663f9f7
fix 23318
rachelruderman 375ae11
skip 23318
rachelruderman c5b33f3
revert try/catch
rachelruderman 171d396
skip 23317
rachelruderman e14fb42
rerun workflow
rachelruderman 1672431
Bump timeout for 'your tests are loading'. Possible fix for 23306
rachelruderman 9fb50f3
rerun workflow
rachelruderman 6294021
merge develop
rachelruderman e73d982
Merge branch 'develop' into fix-or-skip-flaky-tests
rachelruderman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,4 +4,4 @@ snapshot: | |
- 1280 | ||
min-height: 1024 | ||
discovery: | ||
network-idle-timeout: 1000 | ||
network-idle-timeout: 750 | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,4 +4,4 @@ snapshot: | |
- 1280 | ||
min-height: 1024 | ||
discovery: | ||
network-idle-timeout: 1000 | ||
network-idle-timeout: 750 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,7 +29,7 @@ export const waitForSpecToFinish = (expectedResults) => { | |
cy.get('.failed > .num').should('contain', '--') | ||
|
||
// Then ensure the tests are running | ||
cy.contains('Your tests are loading...').should('not.exist') | ||
cy.contains('Your tests are loading...', { timeout: 10000 }).should('not.exist') | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hopeful fix for #23306 |
||
|
||
// Then ensure the tests have finished | ||
cy.get('[aria-label="Rerun all tests"]', { timeout: 30000 }) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addresses Percy non-failing error: