Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add package.json metadata for webpack-dev-server #22292

Merged
merged 1 commit into from
Jun 13, 2022
Merged

fix: add package.json metadata for webpack-dev-server #22292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions npm/vue2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
"unpkg": "dist/cypress-vue2.browser.js",
"module": "dist/cypress-vue2.esm-bundler.js",
"publishConfig": {
"access": "public",
"registry": "http://registry.npmjs.org/"
"access": "public"
}
}
12 changes: 11 additions & 1 deletion npm/webpack-dev-server/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,15 @@
},
"files": [
"dist"
]
],
"license": "MIT",
"repository": {
"type": "git",
"url": "https://github.com/cypress-io/cypress.git"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, @ryanthemanuel i bet this is why we were getting "authenticity cannot be established" - we were using git+ssh, and having repository.url set can force npm to use https instead, avoiding known_hosts verification. kudos @ZachJW34 for actually tracking this down

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

although i don't think you were touching these files when you first ran into it 😕

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Glad I could (unknowingly) help 😅

},
"homepage": "https://github.com/cypress-io/cypress/tree/master/npm/webpack-dev-server#readme",
"bugs": "https://github.com/cypress-io/cypress/issues/new?template=1-bug-report.md",
"publishConfig": {
"access": "public"
}
}