Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: text events propagate out of shadow root. #19132

Merged
merged 1 commit into from
Dec 2, 2021

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Nov 29, 2021

User facing changelog

Typing events now correctly propagate out of the shadow DOM.

Additional details

  • Why was this change necessary? => By default, text events don't propagate out of shadow root. This behavior sometimes causes some unexpected failures.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => I followed the convention of cy.click() fixed at simulated mouse fixes, rightclick, dblclick #3030.

How has the user experience changed?

Before: Text events don't propagate out of shadow root boundary.
After: They do.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 29, 2021

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review November 30, 2021 01:04
@sainthkh sainthkh requested a review from a team as a code owner November 30, 2021 01:04
@sainthkh sainthkh requested review from jennifer-shehane and ryanthemanuel and removed request for a team November 30, 2021 01:04
@chrisbreiding chrisbreiding merged commit f85c736 into cypress-io:develop Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event listeners not working in custom elements
4 participants