Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GH env variable for test other projects #18147

Merged
merged 5 commits into from
Sep 17, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions circle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ macBuildFilters: &macBuildFilters
branches:
only:
- develop
- fix-test-other-projects
- tgriesser/chore/fix-release

defaults: &defaults
parallelism: 1
Expand Down Expand Up @@ -42,7 +42,7 @@ onlyMainBranches: &onlyMainBranches
branches:
only:
- develop
- fix-test-other-projects
- tgriesser/chore/fix-release
requires:
- create-build-artifacts

Expand Down Expand Up @@ -1481,7 +1481,7 @@ jobs:
- run:
name: Check current branch to persist artifacts
command: |
if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "fix-test-other-projects" ]]; then
if [[ "$CIRCLE_BRANCH" != "develop" && "$CIRCLE_BRANCH" != "tgriesser/chore/fix-release" ]]; then
echo "Not uploading artifacts or posting install comment for this branch."
circleci-agent step halt
fi
Expand Down Expand Up @@ -2117,7 +2117,7 @@ linux-workflow: &linux-workflow
branches:
only:
- develop
- fix-test-other-projects
- tgriesser/chore/fix-release
requires:
- build
- test-kitchensink:
Expand All @@ -2129,7 +2129,7 @@ linux-workflow: &linux-workflow
branches:
only:
- develop
- fix-test-other-projects
- tgriesser/chore/fix-release
requires:
- build
- create-build-artifacts:
Expand Down Expand Up @@ -2179,15 +2179,15 @@ linux-workflow: &linux-workflow
branches:
only:
- develop
- fix-test-other-projects
- tgriesser/chore/fix-release
requires:
- create-build-artifacts
- test-npm-module-and-verify-binary:
filters:
branches:
only:
- develop
- fix-test-other-projects
- tgriesser/chore/fix-release
requires:
- create-build-artifacts
- test-binary-against-staging:
Expand All @@ -2196,7 +2196,7 @@ linux-workflow: &linux-workflow
branches:
only:
- develop
- fix-test-other-projects
- tgriesser/chore/fix-release
requires:
- create-build-artifacts

Expand All @@ -2221,7 +2221,7 @@ linux-workflow: &linux-workflow
branches:
only:
- develop
- fix-test-other-projects
- tgriesser/chore/fix-release
requires:
- create-build-artifacts

Expand Down Expand Up @@ -2293,7 +2293,7 @@ mac-workflow: &mac-workflow
branches:
only:
- develop
- fix-test-other-projects
- tgriesser/chore/fix-release
requires:
- darwin-create-build-artifacts

Expand All @@ -2305,7 +2305,7 @@ mac-workflow: &mac-workflow
branches:
only:
- develop
- fix-test-other-projects
- tgriesser/chore/fix-release
requires:
- darwin-create-build-artifacts

Expand Down
5 changes: 3 additions & 2 deletions scripts/binary/bump.js
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ const awaitEachProjectAndProvider = function (projects, fn, filter = R.identity)

if (check.unemptyString(creds.githubToken)) {
providers.travis = {
githubToken: creds.githubToken,
githubToken: process.env.GH_TOKEN,
}
}

Expand Down Expand Up @@ -217,6 +217,7 @@ module.exports = {
console.log('do we have GH_APP_ID?', Boolean(process.env.GH_APP_ID))
console.log('do we have GH_INSTALLATION_ID?', Boolean(process.env.GH_INSTALLATION_ID))
console.log('do we have GH_PRIVATE_KEY?', Boolean(process.env.GH_PRIVATE_KEY))
console.log('do we have GH_TOKEN?', Boolean(process.env.GH_TOKEN))

const parsedRepo = parse(project)
const owner = parsedRepo[0]
Expand Down Expand Up @@ -249,7 +250,7 @@ Testing new Cypress version ${version}
owner,
repo,
message,
token: creds.githubToken,
token: process.env.GH_TOKEN,
}

const createGithubCommitStatusCheck = function ({ sha }) {
Expand Down
16 changes: 8 additions & 8 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -5201,10 +5201,10 @@
"@octokit/types" "^6.0.3"
universal-user-agent "^6.0.0"

"@octokit/openapi-types@^10.1.4":
version "10.1.5"
resolved "https://registry.npmjs.org/@octokit/openapi-types/-/openapi-types-10.1.5.tgz#deafbec805896ae963d7d3846e70b18003cafda1"
integrity sha512-OoShNYzhAU8p8JbGHe1rRs1GIErRtmN2230AQCJAjL5lc0AUU5OhppVe6693HIZ2eCBLUhoLPhnnnmQ5ASH7Wg==
"@octokit/openapi-types@^10.2.2":
version "10.2.2"
resolved "https://registry.yarnpkg.com/@octokit/openapi-types/-/openapi-types-10.2.2.tgz#6c1c839d7d169feabaf1d2a69c79439c75d979cd"
integrity sha512-EVcXQ+ZrC04cg17AMg1ofocWMxHDn17cB66ZHgYc0eUwjFtxS0oBzkyw2VqIrHBwVgtfoYrq1WMQfQmMjUwthw==

"@octokit/plugin-enterprise-rest@^3.6.1":
version "3.6.2"
Expand Down Expand Up @@ -5346,11 +5346,11 @@
"@types/node" ">= 8"

"@octokit/types@^6.0.3", "@octokit/types@^6.16.1", "@octokit/types@^6.27.1":
version "6.27.1"
resolved "https://registry.npmjs.org/@octokit/types/-/types-6.27.1.tgz#88ec25f0cff5fb637c475cf420a0a2e35ba564c7"
integrity sha512-p8VR2OTO1ozxqdAvPeCDDMNmcBzkOL6sPogy2MaEQCapbeWcWNDbwZnqMT3VTZ0DLBBAO0PyHYzU8bA99zd1Fg==
version "6.28.1"
resolved "https://registry.yarnpkg.com/@octokit/types/-/types-6.28.1.tgz#ab990d1fe952226055e81c7650480e6bacfb877c"
integrity sha512-XlxDoQLFO5JnFZgKVQTYTvXRsQFfr/GwDUU108NJ9R5yFPkA2qXhTJjYuul3vE4eLXP40FA2nysOu2zd6boE+w==
dependencies:
"@octokit/openapi-types" "^10.1.4"
"@octokit/openapi-types" "^10.2.2"

"@opentelemetry/[email protected]":
version "0.14.0"
Expand Down