chore: remove Firefox < 80 auto garbage collection #17368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
5 tasks
flotwig
changed the title
flotwig
changed the title
flotwig
force-pushed
the
remove-ff-auto-gc
branch
from
035aa47 to
ad35833
Compare
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||
chrisbreiding
approved these changes
Jul 19, 2021
This was a workaround added to fix a bug in FF < 80. Since Cy removed support for FF < 86 in #17355, this is effectively dead code. This does not remove the ability for users to manually run `Cypress.backend('firefox:force:gc')`.
flotwig
force-pushed
the
remove-ff-auto-gc
branch
from
ad35833 to
159db71
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a workaround added to fix a bug in FF < 80. Since Cy removed support for FF < 86 in #17355, this is effectively dead code.
This does not remove
Cypress.backend('firefox:force:gc').User facing changelog
n/a
Additional details
How has the user experience changed?
PR Tasks
wait for feat: error/warn on unsupported browser versions #17355 to be merged, rebase onto 8.0-release
Have tests been added/updated?
Has the original issue or this PR been tagged with a release in ZenHub?
Has a PR for user-facing changes been opened in
cypress-documentation?Have API changes been updated in the
type definitions?Have new configuration options been added to the
cypress.schema.json?