refactor: remove project token, unused since 0.19.0 #17039
Conversation
|
Thanks for taking the time to open a PR!
|
| @@ -41,11 +41,11 @@ class RunsList extends Component { | |||
| componentDidMount () { | |||
| this._pingApiServer() | |||
| this._handlePolling() | |||
| this._getKey() | |||
| this._getRecordKeys() | |||
There was a problem hiding this comment.
this is an unrelated rename correct?
There was a problem hiding this comment.
@bkucera yeah somewhat, basically just being more explicit about what it's doing.
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
|
@tgriesser Would this be technically breaking anything for 0.19.0 users? Will probably lump in with 8.0 if so which is upcoming really soon. |
|
@jennifer-shehane nah, and I would be shocked if there were any active users of Cypress 0.19.0 🤣. But it's just deleting unused code basically |
tgriesser
changed the title
tgriesser
changed the title
Additional details
Noticed this while going through the
project-basecode, figured we could rip this out since it's no longer supported in the dashboard.PR Tasks
cypress-documentation?type definitions?cypress.schema.json?