cli: print NODE_OPTIONS when DEBUG=cypress... is used, close #1673 #1675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bahmutov
commented
May 3, 2018
bahmutov
commented
- closes If DEBUG=cypress variable is set, print NODE_OPTIONS too #1673 and allows easier tracking of options that can break Node execution (and thus Cypress run)
jennifer-shehane
requested review from
jennifer-shehane
and removed request for
brian-mann
jennifer-shehane
approved these changes
May 15, 2018
There was a problem hiding this comment.
I suppose this will be helpful when asking users of Cypress to print their debug logs, seeing that they have NODE_OPTIONS set would definitely allow us to more quickly point to the existing issue of cypress exiting with 0 with they are set: #1676
Manually checked that this does print NODE_OPTIONS for cli when running in debug mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.