chore(deps): remove underscore and backbone as dev dependencies
#16407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
requested review from
flotwig and
jennifer-shehane
and removed request for
a team
|
See the guidelines for reviewing dependency updates for info on how to review dependency update PRs. |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
renovate
bot
force-pushed
the
renovate/npm-underscore-vulnerability
branch
from
8435d2a to
cc44547
Compare
jennifer-shehane
changed the title
underscore and backbone as dev dependencies
jennifer-shehane
requested review from
kuceb and
chrisbreiding
and removed request for
jennifer-shehane
kuceb
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edited by @jennifer-shehane
Removes
underscoreandbackboneas dev dependencies from the project.Additional Details
This started out as a renovate PR to fix an underscore vulnerability, but then I saw:
serverdoesn't even use theunderscoredevDep that we're installing?driveronly uses theunderscoredevDep for a single driver test that requires Backbone. I rewrote the test so it doesn't require Backbone (andunderscoreas it's peer dep). So, this also removesbackboneas a devDep from the driver. I assume this test has parity, but also this is such an old test who even knows if the code to fix it still exists in the driver.