Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show help on unknown option 837 #1615

Merged
merged 4 commits into from
May 15, 2018
Merged

Show help on unknown option 837 #1615

merged 4 commits into from
May 15, 2018

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Apr 19, 2018 •
edited by jennifer-shehane
Loading

@bahmutov bahmutov requested a review from brian-mann April 19, 2018 13:15
@jennifer-shehane jennifer-shehane self-requested a review April 20, 2018 00:43
jennifer-shehane
jennifer-shehane approved these changes May 15, 2018
View reviewed changes
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this is definitely a better user experience 👍

@jennifer-shehane jennifer-shehane removed the request for review from brian-mann May 15, 2018 16:27
@jennifer-shehane jennifer-shehane merged commit 1f1935b into develop May 15, 2018
@jennifer-shehane jennifer-shehane deleted the show-help-on-unknown-option-837 branch July 24, 2018 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifer-shehane jennifer-shehane jennifer-shehane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show CLI help when user passed unknown option
2 participants
@bahmutov @jennifer-shehane