fix: do not hard-code chrome for interactive e2e #15837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
agg23
approved these changes
Apr 7, 2021
Comment on lines
+7
to
+11
| const browserMap = installedBrowsers.reduce((acc, curr) => { | ||
| acc[curr.name] = true | ||
|
|
||
| return serverCt.start(projectRoot, options) | ||
| return acc | ||
| }, {}) |
There was a problem hiding this comment.
Is there an objective reason that is better?
There was a problem hiding this comment.
Oops I merged, I'll make this change when I'm in this area again (prob soon). Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Do not assume chrome exists on every machine when launching the component testing runner in interactive mode.
Additional details
Some machines will not have chrome installed. In that case, we fall back to chromium -> edge -> electron etc.
How has the user experience changed?
Do not throw an error when running
yarn cypress open-ctif Chrome is not installed.PR Tasks