-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Fire run events in interactive mode #15787
Conversation
Thanks for taking the time to open a PR!
|
Huzza!
…Sent from my iPhone
On Apr 5, 2021, at 10:03, cypress-bot[bot] ***@***.***> wrote:
Thanks for taking the time to open a PR!
Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this will allow people who want to start their web server before running tests to move their logic in a 'before:run' event as opposed to logic danging in the pluginsFile
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
before:spec
,after:spec
,before:run
, andafter:run
can now fire in interactive mode in addition to run mode. This requires theexperimentalInteractiveRunEvents
flag to be enabled.Additional details
before:run
fires when opening a project. It has more limited system information than in run mode.before:spec
fires when the browser opensafter:spec
fires when the browser closes (and may not fire at all (if, for example, you force quit Cypress). It only has the spec argument and not the results.after:run
fires when you close the project (and may not fire at all (if, for example, you force quit Cypress). It does not have the results argument.PR Tasks
cypress-documentation
? feat: Update run events pages with interactive mode details cypress-documentation#3791type definitions
?cypress.schema.json
?