Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fire run events in interactive mode #15787

Merged
merged 5 commits into from
Apr 12, 2021

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Apr 5, 2021

User facing changelog

  • The events before:spec, after:spec, before:run, and after:run can now fire in interactive mode in addition to run mode. This requires the experimentalInteractiveRunEvents flag to be enabled.

Additional details

  • before:run fires when opening a project. It has more limited system information than in run mode.
  • before:spec fires when the browser opens
  • after:spec fires when the browser closes (and may not fire at all (if, for example, you force quit Cypress). It only has the spec argument and not the results.
  • after:run fires when you close the project (and may not fire at all (if, for example, you force quit Cypress). It does not have the results argument.

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 5, 2021

Thanks for taking the time to open a PR!

@bahmutov
Copy link
Contributor

bahmutov commented Apr 5, 2021 via email

@cypress
Copy link

cypress bot commented Apr 6, 2021



Test summary

9494 0 111 3Flakiness 0


Run details

Project cypress
Status Passed
Commit 39c5a5a
Started Apr 12, 2021 6:50 PM
Ended Apr 12, 2021 7:01 PM
Duration 11:50 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

@kuceb kuceb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this will allow people who want to start their web server before running tests to move their logic in a 'before:run' event as opposed to logic danging in the pluginsFile

@chrisbreiding chrisbreiding merged commit b53f04e into develop Apr 12, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 12, 2021

Released in 7.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 12, 2021
@chrisbreiding chrisbreiding deleted the TR-701-run-events-interactive-mode branch April 5, 2022 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants