-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress.dom.isDetached missing from Typescript types #4408
Comments
@jennifer-shehane Do you mind if I pick this up? Also should we add all of the dom functions to the declaration file? It looks like there are a good deal more in dom/index.js that could be added. |
@kylerob Go for it. |
@jennifer-shehane or @kylerob any progress on this? I have
and I am still seeing this issue |
The code for this is done in cypress-io/cypress#5298, but has yet to be released. |
* updates events viewer test * updates login tasks * updates ml conditional links * updates url state * updates timeline screen * updates timeline tasks * updates test files * adds jenkins needed files * ignoring isAttached lines due to a known error in Cypress (cypress-io/cypress#4408) * updates loop script * updates readme with new cypress command explanation * removes skip Co-authored-by: Elastic Machine <[email protected]>
* updates events viewer test * updates login tasks * updates ml conditional links * updates url state * updates timeline screen * updates timeline tasks * updates test files * adds jenkins needed files * ignoring isAttached lines due to a known error in Cypress (cypress-io/cypress#4408) * updates loop script * updates readme with new cypress command explanation * removes skip Co-authored-by: Elastic Machine <[email protected]>
* updates events viewer test * updates login tasks * updates ml conditional links * updates url state * updates timeline screen * updates timeline tasks * updates test files * adds jenkins needed files * ignoring isAttached lines due to a known error in Cypress (cypress-io/cypress#4408) * updates loop script * updates readme with new cypress command explanation * removes skip Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Current behavior:
The method
Cypress.dom.isDetached()
type errors in Typescript projects.Desired behavior:
The method
Cypress.dom.isDetached()
does not type error in Typescript projects.Steps to reproduce: (app code and test code)
Versions
Cypress 3.2.0
Typescript 3.4.5
Chrome 74.0.3729.169
macOS 10.14.5
The text was updated successfully, but these errors were encountered: