-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing browserCriClient in connectToNewSpec #24650
Comments
@jazpearson Don't know if this helps but stumbled across this when trying to figure out why our own CI pipeline was breaking with this error message after upgrading agents to 10.11.0. In our case the error was being caused by our test director (sorry-cypress) and ultimately was due to this off-by-one error sorry-cypress/sorry-cypress#613 which has since been fixed. |
Hi @jazpearson , I'm sorry to hear you are having problems using Cypress. Unfortunately without a reproducible example, we wont be able to further assist you. If you can figure out a way to reproduce this issue that you can share with us please do comment here and we can reopen the issue. |
I am also seeing this error with Cypress 10.11 when running on Jenkins pipeline. This happens very rarely.
|
Hi @tommy0831 , can you provide a reproducible example that our engineers can use to debug further? |
One thing i did do was to update these two libraries that i had installed:
I don't know if it was coincidence or not, but that did help improve things. It still happens, but it's reasonably rare at the minute. Maybe happens 1/20 times, whereas before it was sometimes as bad as 1/4. I wish i could provide a sample, but i'm under NDA. This is currently some of our reporting 3rd party components.
|
Happened to me also. Anything new on this issue? |
Hi @matanbanin , We still do not have a reproducible example for our Cypress devs to use to debug this issue. If you can provide one I will reopen the ticket for further investigation. |
Hello, I am also seeing this error. I am running my tests locally (not in ci). These are the dev dependencies:
I have never seen this error before. All I did was run tests, but today I managed to see it a few times already. |
Hi @swatinigam , Do you have a reproducible example by chance? So far no one has been able to provide us with a reproducible example to help us debug this issue. Without being able to reproduce the issue it is extremely unlikely we will find a solution. If you can share one that would allow us to move this ticket forward. |
It's happening just not reproducible. happens for about 2% of builds |
This seems to be the same issue as #22451, however the error is being thrown correctly here, where as it's getting one line of code further in #22451... we had identified it as a mistake on how we are re-launching a browser after the first spec if the browser process is corrupt. This error is occurs here: https://github.com/cypress-io/cypress/blob/7721e2be9d7cd6695a16385f3a8965625da162c4/packages/server/lib/browsers/chrome.ts |
Awesome! any idea on how much time will take to deploy a fix? Is there any safe version to rollback to? |
Hello, i've got the same error for no reason today :
Any news about that ? |
Any update on this issue? Since a few months we are experiencing the same and currently are getting this error multiple times per day, even with the test suites just running once per hour in CircleCI. We're on We're also experiencing issue #747, in case it's related. |
It's hard to say without a reliable way to reproduce this, but there's a chance this is fixed by #25898. It will be out with the next release, but if you'd like to check it out ahead of time, I'd recommend installing the prerelease build for the latest commit on the develop branch. |
@chrisbreiding hello, i still got the error only on gitlab (of course) after updating Cypress to 12.7.0, and i've no idea on how to reproduce it because, it works sometime, and some other time it fail. |
Unfortunately we are still seeing this issue in 12.7.0 |
We're still seeing this issue sporadically in our GoCD pipeline and we've upgraded to |
Is there anything we can add to help debug this? I know we want a reproducible repo, but it seems most of us aren't in a position to share our code. This is starting to cripple us, as we've added more tests, the chances of this happening has gone up, and we are having to run tests multiple times to check for passes. Our tests take over an hour to run now. Seeing this issue in 12.9.0 |
It happens with "cypress": "^12.4.1", too: other dependencies:
I think it is somehow related to the cucumber-preprocessor. I executed locally, in headless mode. |
I've also seen the issue in several 12.x versions (I'm currently on 12.9.0, where it also occurs). |
@nagash77 @chrisbreiding we're still seeing this issue. I'm not under any kind of NDA with my company's code and am happy to work with someone from Cypress to show you this issue and let you see our overall setup, if that helps at all? |
@chrisbreiding Any update on this issue? Unfortunately this is rapidly becoming a showstopper for us. Can anyone provide any suggestions on how to mitigate the issue as we are seeing it almost 100% of our runs in the CI/CD environment. |
We're still seeing this issue 1 in every 10 builds, and have resorted to splitting off a small subset of our tests to run in just the prod stage of our GoCD pipeline instead of running them all just in preprod. We're yet to see the issue occur since we've done this. We have a quick enough feedback loop and release/rollback process so we can react to any issues flagged by our Cypress tests in prod quickly enough. Not an ideal solution, and won't be an option for all experiencing this issue. However this does highlight that the length of the test suite has something to do with why we were experiencing the issue. @chrisbreiding my offer still stands to work with you and show you our codebase, pipeline and test setup if any of this info might help you understand what's causing the issue. |
Still happening in 12.10.0 |
Hi everyone, thought I'd give an update on something we've changed which has so far stopped this issue from occurring. We've increased the Previously it was set to:
and now we've updated it to be:
Like I said, since this change we haven't seen the browserCriClient issue once in our CI pipeline (we'd never encountered this locally). Our original memory must have been set a while ago, and we haven't thought to change it until now. We thought it might need bumping up after spotting this in the "Hardware" section of getting started, the part about running tests reliably. Hopefully others experiencing this issue can give this a try and share if it works for them too. Good luck everyone. |
Any update ? We don't use docker image and it still appearing sometime. |
We are running 12.11.0 and having to run builds mutliple times to get past this issue. It's becoming unworkable and we've invested so much time into creating these tests, We aren't using docker compose. |
#25844 looks like another case was described here, but with reproducible code? but this issue was told it was a duplicate of this one.... |
I've submitted a PR in the hope to get some attention to this issue, because it's really hurting us now. |
The same happens on version 12.13.0. |
Hey @jazpearson . I put together #27116 which I think might fix this issue. I will work on getting a binary built and mentioning it on this issue. In the meantime, I am going to close #26882 since I don't believe it is going to fix your issue as recreating the CRI client in that context will just give the wrong port and refuse the connection. I'll keep this issue up to date once I get a binary! |
That's fantasic, thanks @AtofStryker. I wasn't convinced my PR would work, and was more to try and get the ball rolling with someone who knew what they were doing. Thanks again - and will look forward to testing things out. |
I meant to update this on Friday, but the binaries with the fix proposed in #27116 are here. @jazpearson confirmed it looks to be working in #24650 (comment), but would love others to try and confirm! |
YAY! Thanks! |
In my testing, i did see the issue happening again, but the frequency seemed to be much reduced from before. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
good to know. There might be an edge case we are missing, but it's going to be hard to determine. If you are able to reproduce it, let us know and we can see how we can improve this fix! |
There is another fix to a similar error like this that will be coming out in 13.13.0, so please update to that version when it releases. PR: #29663 |
Current behavior
Unfortunately, this issue is intermittent and only happens in our CI pipeline. But i wanted to see if could raise the issue in case there's something obvious.
We run cypress with the following:
cypress-run cross-env NODE_OPTIONS=--max-http-header-size=1000000 cypress run --browser chrome
. And we run in a docker container, using the cypress/included images.This error happens mid-way running through our test suites. Our tests can take 30 minutes, and the following error seems to occur when ending a test suite (or conversely, when starting the next test suite).
When this happens, the test run completely exits and the remaining suites do not run.
Desired behavior
For the test run not to crash
Test code to reproduce
Really difficult to do, sorry. It's intermittent, and it's a fairly large, sensitive, code-base.
Cypress Version
11.0.1
Node version
16.16.0
Operating System
Jenkins CI - CentOS (but runs the cypress docker image)
Debug Logs
No response
Other
We've seen this happening in v10 and v11.
The text was updated successfully, but these errors were encountered: