-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flaky test: Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/root/cypress/packages/data-context/test/unit/sources/GitDataSource.spec.ts) #23317
Comments
Added |
Looked at this as part of #25671 - retries can be added, but it fails persistently if it flakes even once. |
Still flaky ... we will fix it, or write a new test that does the same thing that isn't flaky. Hey team! Please add your planning poker estimate with Zenhub @astone123 @marktnoonan @mike-plummer @warrensplayer @ZachJW34 |
Hey team! Please add your planning poker estimate with Zenhub @astone123 @lmiller1990 @marktnoonan @mike-plummer @ZachJW34 |
I'd like to limit this to half a day max - I'd also like to know if we've already got coverage for this somewhere else, and if we do, just delete this test. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Link to dashboard or CircleCI failure
https://app.circleci.com/pipelines/github/cypress-io/cypress/41761/workflows/4f6901d8-6339-4309-b284-e03055666f1c/jobs/1732010
Link to failing test in GitHub
https://github.com/cypress-io/cypress/blob/develop/packages/data-context/test/unit/sources/GitDataSource.spec.ts#L46
Analysis
The missing
done
doesn't fix the test failure -- it's a symptom of the test failure. That said, the missingdone
is an easy fix and will help us see the actual error that's happening. To do so, let's just add a try/catch, where the try ends withdone()
and the catch ends withdone(new Error(error))
Cypress Version
10.4.0
Other
Search for this issue number in the codebase to find the test(s) skipped until this issue is fixed
The text was updated successfully, but these errors were encountered: