Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: Error: Timeout of 2000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/root/cypress/packages/data-context/test/unit/sources/GitDataSource.spec.ts) #23317

Closed
rachelruderman opened this issue Aug 12, 2022 · 6 comments · Fixed by #26179
Assignees
Labels
OS: linux process: flaky test Related to test(s) that have flake in our internal tests

Comments

@rachelruderman
Copy link
Contributor

rachelruderman commented Aug 12, 2022

Link to dashboard or CircleCI failure

https://app.circleci.com/pipelines/github/cypress-io/cypress/41761/workflows/4f6901d8-6339-4309-b284-e03055666f1c/jobs/1732010

Link to failing test in GitHub

https://github.com/cypress-io/cypress/blob/develop/packages/data-context/test/unit/sources/GitDataSource.spec.ts#L46

Analysis

The missing done doesn't fix the test failure -- it's a symptom of the test failure. That said, the missing done is an easy fix and will help us see the actual error that's happening. To do so, let's just add a try/catch, where the try ends with done() and the catch ends with done(new Error(error))

Screen Shot 2022-08-12 at 11 21 07 AM

Cypress Version

10.4.0

Other

Search for this issue number in the codebase to find the test(s) skipped until this issue is fixed

@rachelruderman
Copy link
Contributor Author

Added .skip to this test in #23167. Please remove .skip when test is stable

@mschile mschile added triage and removed triage labels Aug 18, 2022
@flotwig flotwig added the process: flaky test Related to test(s) that have flake in our internal tests label Feb 1, 2023
@flotwig
Copy link
Contributor

flotwig commented Feb 2, 2023

Looked at this as part of #25671 - retries can be added, but it fails persistently if it flakes even once.

@lmiller1990
Copy link
Contributor

lmiller1990 commented Feb 23, 2023

Still flaky ... we will fix it, or write a new test that does the same thing that isn't flaky.

Hey team! Please add your planning poker estimate with Zenhub @astone123 @marktnoonan @mike-plummer @warrensplayer @ZachJW34

@warrensplayer
Copy link
Contributor

@lmiller1990
Copy link
Contributor

I'd like to limit this to half a day max - I'd also like to know if we've already got coverage for this somewhere else, and if we do, just delete this test.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 28, 2023

Released in 12.9.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.9.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
OS: linux process: flaky test Related to test(s) that have flake in our internal tests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants