Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky test: <OpenBrowserList /> throws when activeBrowser is null #23099

Closed
rachelruderman opened this issue Aug 3, 2022 · 3 comments
Closed
Labels
OS: linux process: flaky test Related to test(s) that have flake in our internal tests stale no activity on this issue for a long period

Comments

@rachelruderman
Copy link
Contributor

rachelruderman commented Aug 3, 2022

Current behavior

This is our top flaky test on Linux, having flaked 440 times in the last 30 days at time of writing. See Dashboard Insights

We're trying to test an error state, but the error itself is causing the test to flake:

Screen Shot 2022-08-03 at 2 55 03 PM

    cy.once('uncaught:exception', (err) => {
     expect(err.message).to.include('Missing activeBrowser in selectedBrowserId')
     done()
   })

Looks like an easy fix, just need to tweak the logic for asserting the error

Desired behavior

No more flake 😃

Test code to reproduce

https://github.com/cypress-io/cypress/blob/develop/packages/launchpad/src/setup/OpenBrowserList.cy.tsx#L134

Cypress Version

10.4.0

Other

#23099

@rachelruderman rachelruderman added topic: flake ❄️ process: flaky test Related to test(s) that have flake in our internal tests and removed process: flaky test Related to test(s) that have flake in our internal tests labels Aug 3, 2022
@cypress-bot cypress-bot bot added stage: investigating Someone from Cypress is looking into this stage: flake and removed stage: fire watch stage: investigating Someone from Cypress is looking into this labels Aug 5, 2022
@rachelruderman rachelruderman removed their assignment Aug 10, 2022
@rachelruderman
Copy link
Contributor Author

Added .skip to this test in #23167. Please remove .skip when test is stable

@mschile mschile added triage and removed triage labels Aug 18, 2022
@flotwig flotwig added the process: flaky test Related to test(s) that have flake in our internal tests label Feb 1, 2023
@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label Aug 1, 2023
@cypress-app-bot
Copy link
Collaborator

This issue has been closed due to inactivity.

@cypress-app-bot cypress-app-bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS: linux process: flaky test Related to test(s) that have flake in our internal tests stale no activity on this issue for a long period
Projects
None yet
Development

No branches or pull requests

4 participants