chore(deps): update dependency semantic-release to v19 [security] (#2…

…2238) * chore(deps): update dependency semantic-release to v19 [security] * chore: try moving to semantic-release 18 * chore: update jasmine-core to 3.8.0 * chore: update semantic version 19.0.3 * fix: update test to deal with npm obscuring internal error code Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Lachlan Miller <[email protected]> Co-authored-by: Bill Glesias <[email protected]>
cypress-io · Jun 27, 2022 · fac83fd · fac83fd · cypress-bot · Jun 27, 2022
1 parent 22d2c31
commit fac83fd
Show file tree

Hide file tree

Showing 6 changed files with 966 additions and 932 deletions.
diff --git a/npm/angular/package.json b/npm/angular/package.json
@@ -55,7 +55,7 @@
     "raw-loader": "1.0.0",
     "renderkid": "2.0.5",
     "rxjs": "~6.6.0",
-    "semantic-release": "17.4.2",
+    "semantic-release": "19.0.3",
     "to-string-loader": "1.1.6",
     "ts-loader": "8.1.0",
     "ts-node": "^10.2.1",

diff --git a/npm/cypress-schematic/sandbox12/package.json b/npm/cypress-schematic/sandbox12/package.json
@@ -28,7 +28,7 @@
     "@angular/compiler-cli": "~13.1.3",
     "@types/jasmine": "~3.6.0",
     "@types/node": "^12.11.1",
-    "jasmine-core": "~3.7.0",
+    "jasmine-core": "~3.8.0",
     "karma": "~6.3.0",
     "karma-chrome-launcher": "~3.1.0",
     "karma-coverage": "~2.0.3",

diff --git a/npm/webpack-preprocessor/package.json b/npm/webpack-preprocessor/package.json
@@ -54,7 +54,7 @@
     "react-dom": "16.13.1",
     "react-scripts": "3.2",
     "rimraf": "3.0.2",
-    "semantic-release": "17.2.3",
+    "semantic-release": "19.0.3",
     "sinon": "^9.0.0",
     "sinon-chai": "^3.5.0",
     "snap-shot-it": "7.9.2",

diff --git a/package.json b/package.json
@@ -196,7 +196,7 @@
     "print-arch": "1.0.0",
     "proxyquire": "2.1.3",
     "rimraf": "3.0.2",
-    "semantic-release": "17.2.3",
+    "semantic-release": "19.0.3",
     "semantic-release-monorepo": "7.0.3",
     "semver": "7.3.2",
     "shelljs": "0.8.5",

diff --git a/packages/server/test/integration/cli_spec.js b/packages/server/test/integration/cli_spec.js
@@ -96,8 +96,17 @@ describe('CLI Interface', () => {
     describe('through NPM script', () => {
       let npmVersion = null
 
-      const isNpmSlurpingCode = () => {
-        return semver.lt(npmVersion, '4.0.0')
+      /**
+       * In certain versions of npm, code with an exit code of 10 (Internal Runtime Javascript Failure)
+       * is ultimately displayed as an exit code of 1 (Uncaught Runtime Exception).
+       * This seems to occur before Node 7 / NPM 4 and after Node 14/ NPM 7.
+       * Please see https://github.com/arzzen/all-exit-error-codes/blob/master/programming-languages/javascript/nodejs.md
+       * for more details.
+       *
+       * @returns {boolean}
+       */
+      const doesNpmObscureInternalExitCode = () => {
+        return semver.lt(npmVersion, '4.0.0') || semver.gt(npmVersion, '6.0.0')
       }
 
       beforeEach(() => {
@@ -111,7 +120,7 @@ describe('CLI Interface', () => {
       })
 
       it('npm slurps up or not exit value on failure', (done) => {
-        const expectedCode = isNpmSlurpingCode() ? 1 : 10
+        const expectedCode = doesNpmObscureInternalExitCode() ? 1 : 10
         const s = cp.exec('npm run dev -- --exit-with-code=10')
 
         return s.on('close', (code) => {