fix(runner-ct): fixing an exception and styling (#15833)

* patch: fixing an exception and styling * reduce icon margin a bit more Co-authored-by: Lachlan Miller <[email protected]>
cypress-io · Apr 7, 2021 · f888625 · f888625 · cypress-bot · Apr 7, 2021
1 parent 702a152
commit f888625
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/packages/runner-ct/src/app/Plugins.tsx b/packages/runner-ct/src/app/Plugins.tsx
@@ -20,7 +20,7 @@ export const Plugins = namedObserver('Plugins',
 
     return (
       <Hidden
-        type="visual"
+        type="layout"
         hidden={!props.state.isAnyPluginToShow}
         className={styles.ctPlugins}
       >

diff --git a/packages/runner-ct/src/app/SpecList/SpecList.module.scss b/packages/runner-ct/src/app/SpecList/SpecList.module.scss
@@ -66,9 +66,13 @@
   margin-inline-start: $text-xs;
 }
 
-.folderIcon, .brandIcon {
-  margin-right: 0.5em;
+.li svg {
+  margin-right: 0.3em;
 }
+// TODO: fix this
+// .folderIcon, .brandIcon {
+//   margin-right: 1em;
+// }
 
 .isClosed {
   + .ul, + .li {

diff --git a/packages/runner-ct/src/app/SpecList/SpecList.tsx b/packages/runner-ct/src/app/SpecList/SpecList.tsx
@@ -357,6 +357,10 @@ export const SpecList: React.FC<SpecListProps> = (props) => {
     if (e.key === 'Enter') {
       const selected = flattenedFiles[selectedSpecIndex]
 
+      if (!selected) {
+        return // enter key doesn't do anything if we couldn't find any specs
+      }
+
       if (selected.type === 'file') {
         // Run the spec.
         props.onFileClick(selected)