fix after merge: use most recent attempt for before/after hooks

cypress-io · Aug 10, 2020 · df26592 · df26592 · cypress-bot · Aug 10, 2020
1 parent cd1119b
commit df26592
Showing 1 changed file with 9 additions and 4 deletions.
diff --git a/packages/driver/src/cypress/runner.js b/packages/driver/src/cypress/runner.js
@@ -859,13 +859,18 @@ const create = (specWindow, mocha, Cypress, cy) => {
 
     const suite = hook.parent
 
+    let foundTest
+
     if (hook.hookName === 'after all') {
-      return findLastTestInSuite(suite, isNotAlreadyRunTest)
+      foundTest = findLastTestInSuite(suite, isNotAlreadyRunTest)
+    } else if (hook.hookName === 'before all') {
+      foundTest = findTestInSuite(suite, isNotAlreadyRunTest)
     }
 
-    if (hook.hookName === 'before all') {
-      return findTestInSuite(suite, isNotAlreadyRunTest)
-    }
+    // if test has retried, we getTestById will give us the last attempt
+    foundTest = foundTest && getTestById(foundTest.id)
+
+    return foundTest
   }
 
   const onScriptError = (err) => {