Skip to content

Commit

Permalink
feat: support data-qa selector in selector playground (#25475)
Browse files Browse the repository at this point in the history
  • Loading branch information
lmiller1990 authored Jan 20, 2023
1 parent 8b1d74f commit ad0b2a3
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ const { $ } = window.Cypress.$Cypress
const SelectorPlayground = Cypress.SelectorPlayground

const SELECTOR_DEFAULTS = [
'data-cy', 'data-test', 'data-testid', 'id', 'class', 'tag', 'attributes', 'nth-child',
'data-cy', 'data-test', 'data-testid', 'data-qa', 'id', 'class', 'tag', 'attributes', 'nth-child',
]

describe('src/cypress/selector_playground', () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/driver/src/cypress/selector_playground.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import uniqueSelector from '@cypress/unique-selector'
import $utils from './utils'
import $errUtils from './error_utils'

const SELECTOR_PRIORITIES = 'data-cy data-test data-testid id class tag attributes nth-child'.split(' ')
const SELECTOR_PRIORITIES = 'data-cy data-test data-testid data-qa id class tag attributes nth-child'.split(' ')

type Defaults = {
onElement: Cypress.SelectorPlaygroundDefaultsOptions['onElement'] | null
Expand Down

3 comments on commit ad0b2a3

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on ad0b2a3 Jan 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.4.0/linux-arm64/develop-ad0b2a37c2fe587f4efe4920d2e445eca5301600/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on ad0b2a3 Jan 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.4.0/linux-x64/develop-ad0b2a37c2fe587f4efe4920d2e445eca5301600/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on ad0b2a3 Jan 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.4.0/win32-x64/develop-ad0b2a37c2fe587f4efe4920d2e445eca5301600/cypress.tgz

Please sign in to comment.