fix: update way that cohorts are cached to remove duplicate key (#23985)

cypress-io · Sep 26, 2022 · 88ecb1e · 88ecb1e · cypress-bot · Sep 26, 2022
1 parent 26a71fe
commit 88ecb1e
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/packages/server/lib/cache.js b/packages/server/lib/cache.js
@@ -186,15 +186,23 @@ module.exports = {
   },
 
   getCohorts () {
-    return fileUtil.get('COHORTS', {})
+    return fileUtil.get('COHORTS', {}).then((cohorts) => {
+      Object.keys(cohorts).forEach((key) => {
+        cohorts[key].name = key
+      })
+
+      return cohorts
+    })
   },
 
   insertCohort (cohort) {
     return fileUtil.transaction((tx) => {
       return tx.get('COHORTS', {}).then((cohorts) => {
         return tx.set('COHORTS', {
           ...cohorts,
-          [cohort.name]: cohort,
+          [cohort.name]: {
+            cohort: cohort.cohort,
+          },
         })
       })
     })

diff --git a/packages/server/test/unit/cohort_spec.ts b/packages/server/test/unit/cohort_spec.ts
@@ -55,7 +55,7 @@ describe('lib/cohort', () => {
 
       return cohorts.set(cohortTest).then(() => {
         return cohorts.getByName(cohortTest.name).then((cohort) => {
-          expect(cohort).to.eq(cohortTest)
+          expect(cohort).to.deep.eq(cohortTest)
         })
       })
     })