Skip to content

Commit

Permalink
chore: put types condition first in the syncing script (#26743)
Browse files Browse the repository at this point in the history
Co-authored-by: Chris Breiding <[email protected]>
  • Loading branch information
Andarist and chrisbreiding authored May 15, 2023
1 parent f0b015e commit 5f5df60
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion cli/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@
"./svelte": {
"types": "./svelte/dist/index.d.ts",
"import": "./svelte/dist/cypress-svelte.esm-bundler.js",
"require": "./svelte/dist/cypress-selte.cjs.js"
"require": "./svelte/dist/cypress-svelte.cjs.js"
}
},
"workspaces": {
Expand Down
10 changes: 5 additions & 5 deletions scripts/sync-exported-npm-with-cli.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ packlist({ path: currentPackageDir })
const subPackageExports = cliPackageConfig.exports[`./${exportName}`] = {}
const esmEntry = isModule ? currentPackageConfig.main : currentPackageConfig.module

if (types) {
// ./react/dist/cypress-react-cjs.js, etc
subPackageExports.types = `./${exportName}/${types}`
}

if (esmEntry) {
// ./react/dist/cypress-react-esm.js, etc
subPackageExports.import = `./${exportName}/${esmEntry}`
Expand All @@ -64,11 +69,6 @@ packlist({ path: currentPackageDir })
subPackageExports.require = `./${exportName}/${currentPackageConfig.main}`
}

if (types) {
// ./react/dist/cypress-react-cjs.js, etc
subPackageExports.types = `./${exportName}/${types}`
}

if (!cliPackageConfig.files.includes(exportName)) {
cliPackageConfig.files.push(exportName)
}
Expand Down

4 comments on commit 5f5df60

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 5f5df60 May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.12.1/linux-arm64/develop-5f5df6043c604aa8899db6d769aa939a2cd0c304/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 5f5df60 May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.12.1/linux-x64/develop-5f5df6043c604aa8899db6d769aa939a2cd0c304/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 5f5df60 May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.12.1/darwin-arm64/develop-5f5df6043c604aa8899db6d769aa939a2cd0c304/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on 5f5df60 May 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release build at https://on.cypress.io/advanced-installation#Install-pre-release-version

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/12.12.1/darwin-x64/develop-5f5df6043c604aa8899db6d769aa939a2cd0c304/cypress.tgz

Please sign in to comment.