Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile added #1549

Closed
wants to merge 1 commit into from
Closed

Dockerfile added #1549

wants to merge 1 commit into from

Conversation

Vozhak
Copy link

@Vozhak Vozhak commented May 17, 2024

Provides the ability to run the app as a Docker container.

@CLAassistant
Copy link

CLAassistant commented May 17, 2024

CLA assistant check
All committers have signed the CLA.

@cypress-app-bot
Copy link

@Vozhak Vozhak marked this pull request as draft May 19, 2024 09:41
@Vozhak Vozhak marked this pull request as ready for review May 19, 2024 09:41
@Vozhak
Copy link
Author

Vozhak commented May 19, 2024

@mjhenkes How can I get a review?

@MikeMcC399
Copy link
Contributor

@Vozhak

Your PR proposes to run Cypress using the Docker image
FROM node:alpine

If you could demonstrate and document how to use a Cypress Docker image locally this could be a useful enhancement. You should provide exact instructions and logs showing a successful run of the tests.

Copy link
Contributor

@MikeMcC399 MikeMcC399 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to use a compatible Docker image and be documented how to use.

@MikeMcC399
Copy link
Contributor

I suggest to close this PR, since there has been no feedback on the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants