chore: upgrade the windows orb

[AtofStryker]

• Closes CircleCI uses Node.js 14.17.5 not 16.16.0 for Windows tests #1354

Upgrades the Circle orb from 4.x.x to 5.x.x and sets up Node 16.16.0 via nvm to be consistent with our other jobs inside circle.

[cypress]

Passing run #6065 ↗︎

0

448

2

0

0

Details:

run ci
Project: cypress-realworld-app	Commit: 5613df8d85
Status: Passed	Duration: 31:25 💡
Started: Jun 1, 2023 2:47 PM	Ended: Jun 1, 2023 3:18 PM

_{This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.}

[MikeMcC399]

@AtofStryker

Thanks very much for making these changes!

• It looks like your tests have hit the issue I reported a while back in Cypress Cloud times out waiting for CircleCI on Windows #1328

[AtofStryker]

@AtofStryker

Thanks very much for making these changes!

• It looks like your tests have hit the issue I reported a while back in Cypress Cloud times out waiting for CircleCI on Windows #1328

Of course! I don't think fixing the timeout issues will be straight forward, but at least we can get on Node 16 here 😅

[AtofStryker]

@MikeMcC399 I have a feeling I am not going to get a passing windows run, am I? 😅

[MikeMcC399]

@AtofStryker

I have a feeling I am not going to get a passing windows run, am I? 😅

I'm seeing the error message:

The run you are attempting to access is already complete and will not accept new groups.

The existing run is: https://cloud.cypress.io/projects/7s5okt/runs

When a run finishes all of its groups, it waits for a configurable set of time before finally completing. You must add more groups during that time period.

The --tag flag you passed was: 
The --group flag you passed was: UI - Electron - Windows
The --parallel flag you passed was: true
The --ciBuildId flag you passed was: 5e647b37

So to get around this, the timeout on Cypress Cloud would need to be increased. Windows takes a long time to set up.

Retriggering CircleCI would probably also not work due the timeout. To retest you would probably better push a new commit.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (761846a) 89.68% compared to head (5613df8) 89.68%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #1356   +/-   ##
========================================
  Coverage    89.68%   89.68%           
========================================
  Files           19       19           
  Lines          737      737           
  Branches        35       35           
========================================
  Hits           661      661           
  Misses          76       76           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[MikeMcC399]

@AtofStryker

Congratulations 🙂 ! Apart from the flaky test (see #1332) it's all working.

So I think this PR can be merged. The other problems are all registered with their own dedicated issues, so these can be followed up separately.