Update auth examples for v12 on custom commands page #4894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AtofStryker
reviewed
Dec 5, 2022
| }) | ||
| ``` | ||
|
|
||
| ```js | ||
| cy.typeLogin({ email: '[email protected]', password: 'Secret1' }) | ||
| cy.loginViaUi({ email: '[email protected]', password: '$ecret1', name: 'johndoe' }) |
There was a problem hiding this comment.
should we also have a loginViaCyOrigin type example here as well that looks similar to the loginViaUI to help give users a pattern to follow?
There was a problem hiding this comment.
it would probably be a light version of what we have with the auth0/okta/cognito guides to show a general cy.origin pattern with cy.session
| cy.get('input[name=email]').type(user.email) | ||
|
|
||
| cy.get('input[name=password]').type(user.password) | ||
| Cypress.Commands.add('loginViaUi', (user) => { |
There was a problem hiding this comment.
Suggested change
| Cypress.Commands.add('loginViaUi', (user) => { | |
| Cypress.Commands.add('loginViaUI', (user) => { |
There was a problem hiding this comment.
This is holy war material mate! https://google.github.io/styleguide/jsguide.html#naming-camel-case-defined
| }) | ||
| ``` | ||
|
|
||
| ```js | ||
| cy.typeLogin({ email: '[email protected]', password: 'Secret1' }) | ||
| cy.loginViaUi({ email: '[email protected]', password: '$ecret1', name: 'johndoe' }) |
There was a problem hiding this comment.
Suggested change
| cy.loginViaUi({ email: '[email protected]', password: '$ecret1', name: 'johndoe' }) | |
| cy.loginViaUI({ email: '[email protected]', password: '$ecret1', name: 'johndoe' }) |
|
Merging this for now, will revisit this content later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4508