feat: add warning about v8 snapshots to troubleshooting guide #4825
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Lachlan Miller <[email protected]>
| The installed application comes with the fully transpiled, unobfuscated | ||
| JavaScript source code that you can hack on. You might want to directly modify | ||
| the installed app code to: |
There was a problem hiding this comment.
With V8 snapshots, "fully transpiled, unobfuscated JavaScript source code" isn't true, right? I think we should remove that language and anything below that doesn't apply with snapshots. The docs only cover the current version of Cypress, so we should target this towards the release-11.0 branch and the verbiage should be more clear about what can and can't be modified by users.
There was a problem hiding this comment.
Ah gotcha. Yeah I thought that we potentially tried to cover multiple versions, but I can update this to be specific to 11.0
There was a problem hiding this comment.
Good call. Thinking about this more, I think this section will cause more confusion than any benefit with leaving it. I decided to remove it instead:
dfbab20 (#4825)
|
|
||
| You can change anything in the JavaScript code: | ||
|
|
||
| <DocsImage src="/img/guides/troubleshooting/source-code.png" alt="Source code of Cypress in a text editor" ></DocsImage> |
There was a problem hiding this comment.
I think we can remove this image as well. It doesn't seem to be referenced anywhere else.
There was a problem hiding this comment.
Removed: 92e4ed8 (#4825)
Add warning about v8 snapshots to troubleshooting guide