Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

10.9.0 Release #4747

Merged
merged 19 commits into from
Sep 27, 2022
Merged

10.9.0 Release #4747

merged 19 commits into from
Sep 27, 2022

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Sep 21, 2022 •
edited
Loading

@vercel
Copy link

vercel bot commented Sep 21, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
cypress-documentation ✅ Ready (Inspect) Visit Preview Sep 27, 2022 at 4:41PM (UTC)

@mjhenkes @emilyrohrbough @chrisbreiding
update docs for async attach feature (#4753)
f850260 
* update docs for async attach feature

* Apply suggestions from code review

Co-authored-by: Emily Rohrbough <[email protected]>

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Chris Breiding <[email protected]>

* fix md issues

Co-authored-by: Emily Rohrbough <[email protected]>
Co-authored-by: Chris Breiding <[email protected]>
@ryanjduffy @lmiller1990
@jaffrepaul @emilyrohrbough @admah
Update browser launch options for env key (#4730)
a0cca06 
Co-authored-by: Lachlan Miller <[email protected]>
Co-authored-by: Paul Jaffre <[email protected]>
Co-authored-by: Emily Rohrbough <[email protected]>
Co-authored-by: Adam Murray <[email protected]>
Co-authored-by: Adam Murray <[email protected]>
BlueWinds
BlueWinds reviewed Sep 27, 2022
View reviewed changes
content/api/commands/origin.md Outdated
```js
it('tests somesite.com', () => {
cy.origin('somesite.com', () => {
// makes custom commands available to all subsequent
Copy link
Contributor

@BlueWinds BlueWinds Sep 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this all subsequent calls within this test, within this spec, or within this cypress run?

Same question for the rest of this section - "persisted between cy.origin callbacks" (for how long?), "makes commands defined in this file available to all callbacks for somesite.com" (all callbacks this cypress run? Wouldn't that imply some pollution / lack of test isolation?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All calls within the spec. I'll update the comment to make that clear.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 59809e4

BlueWinds
BlueWinds reviewed Sep 27, 2022
View reviewed changes
content/api/commands/origin.md Outdated
interactions with the window are performed within the block which can
communicate with the cross-origin page

#### Incorrect usage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#### Incorrect usage
#### **<Icon name="exclamation-triangle" color="red"></Icon> Incorrect Usage**

Should this have the red exclamation triangle?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like it would make sense, though you should probably render it to see what the bolding and heading level do together ####

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:

Screen Shot 2022-09-27 at 12 21 33 PM

Addressed in 59809e4

elylucas
elylucas suggested changes Sep 27, 2022
View reviewed changes
content/api/cypress-api/require.md Outdated

## Examples

See [`cy.origin()` Dependencies / Sharing Code]() for example usages.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is currently missing the link

elylucas
elylucas reviewed Sep 27, 2022
View reviewed changes
content/api/cypress-api/require.md Outdated

## Examples

See [`cy.origin()` Dependencies / Sharing Code]() for example usages.
Copy link
Contributor

@elylucas elylucas Sep 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See [`cy.origin()` Dependencies / Sharing Code]() for example usages.
See [`cy.origin()` Dependencies / Sharing Code](/api/commands/origin#Dependencies-Sharing-Code) for example usages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Fixed in 5653543

@chrisbreiding chrisbreiding merged commit f0fa22d into master Sep 27, 2022
@chrisbreiding chrisbreiding deleted the release-10.9.0 branch September 27, 2022 16:51
@snyk-bot snyk-bot mentioned this pull request May 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjhenkes mjhenkes mjhenkes approved these changes

@AtofStryker AtofStryker AtofStryker approved these changes

@BlueWinds BlueWinds BlueWinds approved these changes

@admah admah admah approved these changes

@elylucas elylucas Awaiting requested review from elylucas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@chrisbreiding @elylucas @mjhenkes @admah @BlueWinds @AtofStryker @emilyrohrbough @ryanjduffy