migration of component testing from 6.X to 7.0 #3759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elevatebart
changed the title
lmiller1990
approved these changes
Mar 30, 2021
amirrustam
approved these changes
Mar 30, 2021
jennifer-shehane
requested changes
Mar 30, 2021
There was a problem hiding this comment.
Committed directly so we can get this in quicker. Just a couple questions I noted in line of the code. Should be good after that.
- Moved the component testing migration further up in migration notes, within 7.0 migration.
- more use of conjunctions
- some spelling fixes
- clarify on some pieces, like config/support files
- shorten code examples to remove scroll
- Component Testing should always be lowercase.
- h5 level to bold since styling is not great.
- other minor editing.
14 tasks
jennifer-shehane
approved these changes
Mar 30, 2021
|
Last I heard @JessicaSachs wanted to review this and confirm the changes. |
…ntation into ct-7-migration
|
It's ready for another review if necessary. I kept the formatting and tried to adhere to the writing style. This is going to break 100% of CT users, so I wanted to provide a thorough migration guide. |
…ntation into ct-7-migration
jennifer-shehane
requested changes
Mar 31, 2021
jennifer-shehane
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.