Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update continuous-integration.md #215

Closed
wants to merge 1 commit into from
Closed

Update continuous-integration.md #215

wants to merge 1 commit into from

Conversation

anned20
Copy link

@anned20 anned20 commented Nov 3, 2017

We were missing x264 from our testing environment and that caused Cypress to hang at processing the video

We were missing x264 from our testing environment and that caused Cypress to hang at processing the video
@CLAassistant
Copy link

CLAassistant commented Nov 3, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jennifer-shehane
Copy link
Member

Hi @anned20. Thanks for contributing! Could you sign our CLA before we accept your contribution?

@brian-mann
Copy link
Member

@bahmutov do we install x264 in our linux docker images?

@bahmutov
Copy link
Contributor

bahmutov commented Nov 3, 2017

No we don't and @anned20 what is your testing environment?

@anned20
Copy link
Author

anned20 commented Nov 3, 2017 via email

@bahmutov
Copy link
Contributor

bahmutov commented Nov 3, 2017

@anned20 is the runtime 32-bit or 64-bit? because we include 64 bit ffmpeg which might crash on 32 bit. This is why in windows build we manually include both ffmpeg version (increasing its size). In the future we should build separate 32-bit and 64-bit builds for every platform

@anned20
Copy link
Author

anned20 commented Nov 3, 2017 via email

@anned20
Copy link
Author

anned20 commented Nov 6, 2017

I just checked and the runtime is 64bit. The Vagrant image is based on "debian/jessie64". The tests are passing (failing), the screenshots are getting print and then it just hangs.

@anned20 anned20 closed this Nov 6, 2017
@anned20
Copy link
Author

anned20 commented Nov 6, 2017

It's not throwing an error either with debug mode on

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants