Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about potential IDE TS server issues #2136

Merged
merged 2 commits into from
Oct 7, 2019

Conversation

kylerob
Copy link
Contributor

@kylerob kylerob commented Oct 5, 2019

closes #1110

I added a warning note about potential IDE TS server issues that may throw off TS setups.

{% note warning %}
You may have to restart your IDE's TypeScript server if the setup above does not appear to work. For example:

VS Code (within a .ts file):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to mention that restart TS server can help with intellisense while in a .ts or .js file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bahmutov Thanks for the review, I'll add js as well.

@jennifer-shehane jennifer-shehane merged commit b3f22ed into cypress-io:develop Oct 7, 2019
@kylerob kylerob deleted the issue-1110 branch October 7, 2019 20:41
jennifer-shehane pushed a commit that referenced this pull request Oct 11, 2019
* Develop (#2059)

* add instrument-cra plugin link

* add another cy.within example

* Fix typo

* lowercase 'TR'


Co-authored-by: Jennifer Shehane <[email protected]>

* Update Continuous Integration doc with details for AWS Amplify… (#2124)

* change 'default org' to 'personal org' (#2133)

* add redirect (#2137)

* Update cypress open --browser section (#2134)



Co-authored-by: Kevin Old <[email protected]>

* Add note about potential IDE TS server issues (#2136)

* add note about potential IDE TS server issues

* include js in file types that support restart command

* Add padding support to element screenshot

See: cypress-io/cypress#5078
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In TypeScript doc, mentioning restarting TS server
3 participants